Date:   Wed, 8 Dec 2021 17:22:02 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     "David E. Box" <david.e.box@linux.intel.com>
Cc:     lee.jones@linaro.org, hdegoede@redhat.com, bhelgaas@google.com,
        andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
        mgross@linux.intel.com, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH RESEND V2 3/6] platform/x86/intel: Move intel_pmt from
 MFD to Auxiliary Bus
Message-ID: <YbDbql39x7Kw6iAC@kroah.com>
References: <20211208015015.891275-1-david.e.box@linux.intel.com>
 <20211208015015.891275-4-david.e.box@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211208015015.891275-4-david.e.box@linux.intel.com>
Precedence: bulk

On Tue, Dec 07, 2021 at 05:50:12PM -0800, David E. Box wrote:
> +static struct pci_driver intel_vsec_pci_driver = {
> +	.name = "intel_vsec",
> +	.id_table = intel_vsec_pci_ids,
> +	.probe = intel_vsec_pci_probe,
> +};

So when the PCI device is removed from the system you leak resources and
have dangling devices?

Why no PCI remove driver callback?

thanks,

greg k-h