Message-ID: <022193b1-4ddd-f04e-aafa-ce249ec6d120@oracle.com>
Date:   Wed, 8 Dec 2021 11:29:47 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] tun: avoid double free in tun_free_netdev
Content-Language: en-CA
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1638974605-24085-1-git-send-email-george.kennedy@oracle.com>
 <YbDR/JStiIco3HQS@kroah.com>
From:   George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <YbDR/JStiIco3HQS@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0R0VnNPbXAvWFVpeXphc2ZjeFdXNURkWWR6NUI1cEJURE4zOUc2aFhJRjVr?=
 =?utf-8?B?bUNyYjBJSlI3NXBZVlFleGNlR1hRNTdJemU0ZnpWM2UwU3FhN1lCRXk1bllN?=
 =?utf-8?B?UHBQaGpvbHhXcUhtZFRzekFlc2h5MlRaV1BnbmRjS2daZWZqZlBMYkpZTmNl?=
 =?utf-8?B?eFg1ZU5zcVVac1BnV0pKdCtuK0dVNTltVVVQTHF2czlHcUt4cmNlaGhOTGJ0?=
 =?utf-8?B?bEpvV1IxVVFLbXF0MFQ0cUhISm81eVZNRUJGdmNmUldnTmJuRE01ZG9mL09D?=
 =?utf-8?B?TkV4ejJONGdXM01IWnZkd3BBMHJNMlZUL3RuK1Q5WmtGejdPOUVmU0VpdFln?=
 =?utf-8?B?S1RLcmlzMFZSK21lZjZENGllY0xNY1JLYVlQUkhDTlR3bitiQ1hxS256alBM?=
 =?utf-8?B?YXlydWdNM3hsSlIxNHhqZ085V0NXcWlPVFJWbUJ3YUNpbmM0TEJGTFNyVGhx?=
 =?utf-8?B?WjkxbDU2Ry9ERldSVytaVUhFSWxkbHJFVEFwa080TWUvbFdJeWtERWZwS0VF?=
 =?utf-8?B?WEFCMjgrbUI4VTMrNHZmamRxeHJTWG5mQ2NMNDBES2VwMXhmeThuN2J4a0Jo?=
 =?utf-8?B?Rlh6TFFpblMwK01mbHUycFJxNVhNNVRKYzJhMzRiMkg5aXlzWmdKNDVJdGZh?=
 =?utf-8?B?YnBmaUV4SEMwNFZOR0xXa0FGNEVnOGdHcVQvZjV4RHJCM3F2d2gyZDAvdmpU?=
 =?utf-8?B?QzdpalhvUmFuSzNDSVA2VGlIQ0V1VE1ucnc1RGZidG9BNjRwc3Y3U2l4UjF0?=
 =?utf-8?B?MzNlNG9vUHF5dldGVUh2K0tnRFNOWU51UXNqVW9ybytFdVNWSFJxeU4yaGtH?=
 =?utf-8?B?VlV3QzJzRXU3SEVneFVBZFp2eVY0RlZUanlIN3JVOUlMNCtxN0VsbjYyTEVB?=
 =?utf-8?B?cFZwUlBxMjhBT1E0Y3FGQXlUY1ZneVlWem85OEsvb0tDbFFZbFlOR1U2cTB0?=
 =?utf-8?B?bnVPVkpBWjE3WnFNREZpaEFqeGNrVGQvMG1ROVNJN3o3NUVUSzNzNW12WWdQ?=
 =?utf-8?B?WFJBNmZjU3JKcjhzOU1LMEd1RHNuOTBtU2FlZXMySEhsOGJQUmhybGdLNFEr?=
 =?utf-8?B?LzZla3Jwdk5URDdhL25pTGhDeENHNTQrWDJsNG5oSWtaZXBXS3F1YnB1Rjlo?=
 =?utf-8?B?L0ZGUmxwMCtpZCtIWXlzc0R3SjVOUlp5eU5CeWdJZ20xc0ZLQ0JwSGxHWTV4?=
 =?utf-8?B?ckdhUUhNU211N2F4N3FNZEZMbTFDaVJNa2hyajZUQ0R4NXF3cVVFanVGV3Ji?=
 =?utf-8?B?Mml5d2R0YzVKdWxVcjhLbXZWMEpGTTlKNEZLejY3MjBrVlJua1ErU1BabGZx?=
 =?utf-8?B?d200aWdpakJFYVgyazNpSWFKazJiQVdBVndzandpMVA1bWFpcFJkNTRKOGtW?=
 =?utf-8?B?UldsWTM2bW11Umo2eDN6b0JNdElrL08rcmdoV21xT2hFT1FUZERxWjVSZkYw?=
 =?utf-8?B?WEk0MUhDdHZLd0FHMFhidE0zNEZsS0lXazdyTERKYXJObVUzd29mM2FpdEl5?=
 =?utf-8?B?QlYvRXpmcXZVSFUza2VDZi9LanJsTzRRaUFHaCtkcjc2M1FTYjlzdjJxYTlZ?=
 =?utf-8?B?WGpzS1NiOEFUbWVVMkhORWg0OEpVQ2k2MVFxSFJKcnJha01NdWQ3eFZvTVlu?=
 =?utf-8?B?eE5iV0VBK1E5eWpNOTR0MG42Mk9PVTAwckJGQlkyaGZ3WWFvWGZydDdJWjJW?=
 =?utf-8?B?c2xUOXRLWll0UTZyMTNzMXpBdmEwVldLM0VaSmxuYVVnUVZvWmtYOG5XTVBr?=
 =?utf-8?B?QjRUUThkU0QyemtwMi9QWnEvbzdBVXN0UHhsamdGdEtReWZwM2Z2U0lwUjlw?=
 =?utf-8?B?TjAzV3V6ZTlaeSthVUR2OU00T1RWeFI3SEJKRCtpNi9MV05YY2JLZjdnQ3or?=
 =?utf-8?B?cThoSTRpdTVpOUcvb05oVG9kM3l3VkEyNGxVbDZZTmQyUkR5ai9XeXRYN0R2?=
 =?utf-8?B?Y0pFdkN4b3gzcE1GalQzR1MwNGxLQmUyS2hyTXNxTzRsZG41bU1KYmhZREJW?=
 =?utf-8?B?SUpGblMya1FXL1RyNTZHVUdwMG9HNXlIWDY0d05xYy8xMU5NRktwMlhoR2lk?=
 =?utf-8?B?UkRFcTVnYWlHcHZuSXB0RVZqdEVzajZiRGxUZ1BvTy9lamdDS29rVGF6elZh?=
 =?utf-8?B?eVN0LytCRnBEL2pKUXk4VTRjKzdWV2haZHErQUVGbi9ZYWtoSlZYeWxJc2NQ?=
 =?utf-8?B?TXFEdXVoRjFlc01zMVBEY0xKWWdnQmU4bUlVRzJCTkFoMDRxaGhPS1c3ZkNR?=
 =?utf-8?B?czA0aXVWa1I1M2NFc1AwRENSS29RPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbdf389c-98e5-48d2-5bb7-08d9ba67f4ea
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5192.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 16:29:50.5064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aitgu3lnGkuTPDZwty0EGpz3I+6cb8VgkF1Sr5ogXSfzngZY5duGAm70ja8p4ZgaPbMv2rHLW0TZexKdA6gQCui9/vqoJxhZ58JPO5Qz694=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2084
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10192 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112080097
X-Proofpoint-GUID: Pboe1l0o5ijh5Fl_4CQZnvSegKUd5myk
X-Proofpoint-ORIG-GUID: Pboe1l0o5ijh5Fl_4CQZnvSegKUd5myk
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/2021 10:40 AM, Greg KH wrote:
> On Wed, Dec 08, 2021 at 09:43:25AM -0500, George Kennedy wrote:
>> Avoid double free in tun_free_netdev() by clearing tun->security
>> after free and using it to indicate that free has already been done.
>>
>> BUG: KASAN: double-free or invalid-free in selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
>>
>> CPU: 0 PID: 25750 Comm: syz-executor416 Not tainted 5.16.0-rc2-syzk #1
>> Hardware name: Red Hat KVM, BIOS
>> Call Trace:
>>   <TASK>
>>   __dump_stack lib/dump_stack.c:88 [inline]
>>   dump_stack_lvl+0x89/0xb5 lib/dump_stack.c:106
>>   print_address_description.constprop.9+0x28/0x160 mm/kasan/report.c:247
>>   kasan_report_invalid_free+0x55/0x80 mm/kasan/report.c:372
>>   ____kasan_slab_free mm/kasan/common.c:346 [inline]
>>   __kasan_slab_free+0x107/0x120 mm/kasan/common.c:374
>>   kasan_slab_free include/linux/kasan.h:235 [inline]
>>   slab_free_hook mm/slub.c:1723 [inline]
>>   slab_free_freelist_hook mm/slub.c:1749 [inline]
>>   slab_free mm/slub.c:3513 [inline]
>>   kfree+0xac/0x2d0 mm/slub.c:4561
>>   selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
>>   security_tun_dev_free_security+0x4f/0x90 security/security.c:2342
>>   tun_free_netdev+0xe6/0x150 drivers/net/tun.c:2215
>>   netdev_run_todo+0x4df/0x840 net/core/dev.c:10627
>>   rtnl_unlock+0x13/0x20 net/core/rtnetlink.c:112
>>   __tun_chr_ioctl+0x80c/0x2870 drivers/net/tun.c:3302
>>   tun_chr_ioctl+0x2f/0x40 drivers/net/tun.c:3311
>>   vfs_ioctl fs/ioctl.c:51 [inline]
>>   __do_sys_ioctl fs/ioctl.c:874 [inline]
>>   __se_sys_ioctl fs/ioctl.c:860 [inline]
>>   __x64_sys_ioctl+0x19d/0x220 fs/ioctl.c:860
>>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>>   do_syscall_64+0x3a/0x80 arch/x86/entry/common.c:80
>>   entry_SYSCALL_64_after_hwframe+0x44/0xae
>>
>> Reported-by: syzkaller <syzkaller@googlegroups.com>
>> Signed-off-by: George Kennedy <george.kennedy@oracle.com>
>> ---
>>   drivers/net/tun.c | 11 +++++++++--
>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index 1572878..617c71f 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -2212,7 +2212,10 @@ static void tun_free_netdev(struct net_device *dev)
>>   	dev->tstats = NULL;
>>   
>>   	tun_flow_uninit(tun);
>> -	security_tun_dev_free_security(tun->security);
>> +	if (tun->security) {
>> +		security_tun_dev_free_security(tun->security);
>> +		tun->security = NULL;
>> +	}
>>   	__tun_set_ebpf(tun, &tun->steering_prog, NULL);
>>   	__tun_set_ebpf(tun, &tun->filter_prog, NULL);
>>   }
>> @@ -2779,7 +2782,11 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
>>   
>>   err_free_flow:
>>   	tun_flow_uninit(tun);
>> -	security_tun_dev_free_security(tun->security);
>> +	if (tun->security) {
>> +		security_tun_dev_free_security(tun->security);
>> +		/* Let tun_free_netdev() know the free has already been done. */
>> +		tun->security = NULL;
> What protects this from racing with tun_free_netdev()?
tun_free_netdev() is called after err_free_flow has already done the 
free. rtnl_lock() and rtnl_unlock() prevent the race.

Here is the full KASAN report:

Syzkaller hit 'KASAN: invalid-free in selinux_tun_dev_free_security' bug.

==================================================================
BUG: KASAN: double-free or invalid-free in 
selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605

CPU: 0 PID: 25750 Comm: syz-executor416 Not tainted 5.16.0-rc2-syzk #1
Hardware name: Red Hat KVM, BIOS 1.13.0-2.module+el8.3.0+7860+a7792d29 
04/01/2014
Call Trace:
  <TASK>
  __dump_stack lib/dump_stack.c:88 [inline]
  dump_stack_lvl+0x89/0xb5 lib/dump_stack.c:106
  print_address_description.constprop.9+0x28/0x160 mm/kasan/report.c:247
  kasan_report_invalid_free+0x55/0x80 mm/kasan/report.c:372
  ____kasan_slab_free mm/kasan/common.c:346 [inline]
  __kasan_slab_free+0x107/0x120 mm/kasan/common.c:374
  kasan_slab_free include/linux/kasan.h:235 [inline]
  slab_free_hook mm/slub.c:1723 [inline]
  slab_free_freelist_hook mm/slub.c:1749 [inline]
  slab_free mm/slub.c:3513 [inline]
  kfree+0xac/0x2d0 mm/slub.c:4561
  selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
  security_tun_dev_free_security+0x4f/0x90 security/security.c:2342
  tun_free_netdev+0xe6/0x150 drivers/net/tun.c:2215
  netdev_run_todo+0x4df/0x840 net/core/dev.c:10627
  rtnl_unlock+0x13/0x20 net/core/rtnetlink.c:112
  __tun_chr_ioctl+0x80c/0x2870 drivers/net/tun.c:3302
  tun_chr_ioctl+0x2f/0x40 drivers/net/tun.c:3311
  vfs_ioctl fs/ioctl.c:51 [inline]
  __do_sys_ioctl fs/ioctl.c:874 [inline]
  __se_sys_ioctl fs/ioctl.c:860 [inline]
  __x64_sys_ioctl+0x19d/0x220 fs/ioctl.c:860
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x3a/0x80 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7fd496f4c289
Code: 01 00 48 81 c4 80 00 00 00 e9 f1 fe ff ff 0f 1f 00 48 89 f8 48 89 
f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 
f0 ff ff 73 01 c3 48 8b 0d b7 db 2c 00 f7 d8 64 89 01 48
RSP: 002b:00007fd497632e28 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000603190 RCX: 00007fd496f4c289
RDX: 0000000020000240 RSI: 00000000400454ca RDI: 0000000000000003
RBP: 0000000000603198 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000060319c
R13: 0000000000021000 R14: 0000000000000000 R15: 00007fd497633700
  </TASK>

Allocated by task 25750:
  kasan_save_stack+0x26/0x60 mm/kasan/common.c:38
  kasan_set_track mm/kasan/common.c:46 [inline]
  set_alloc_info mm/kasan/common.c:434 [inline]
  ____kasan_kmalloc mm/kasan/common.c:513 [inline]
  __kasan_kmalloc+0x8d/0xb0 mm/kasan/common.c:522
  kasan_kmalloc include/linux/kasan.h:269 [inline]
  kmem_cache_alloc_trace+0x18a/0x2d0 mm/slub.c:3261
  kmalloc include/linux/slab.h:590 [inline]
  kzalloc include/linux/slab.h:724 [inline]
  selinux_tun_dev_alloc_security+0x50/0x180 security/selinux/hooks.c:5594
  security_tun_dev_alloc_security+0x51/0xb0 security/security.c:2336
  tun_set_iff.constprop.66+0x107f/0x1d10 drivers/net/tun.c:2727
  __tun_chr_ioctl+0xdf8/0x2870 drivers/net/tun.c:3026
  tun_chr_ioctl+0x2f/0x40 drivers/net/tun.c:3311
  vfs_ioctl fs/ioctl.c:51 [inline]
  __do_sys_ioctl fs/ioctl.c:874 [inline]
  __se_sys_ioctl fs/ioctl.c:860 [inline]
  __x64_sys_ioctl+0x19d/0x220 fs/ioctl.c:860
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x3a/0x80 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x44/0xae

Freed by task 25750:
  kasan_save_stack+0x26/0x60 mm/kasan/common.c:38
  kasan_set_track+0x25/0x30 mm/kasan/common.c:46
  kasan_set_free_info+0x24/0x40 mm/kasan/generic.c:370
  ____kasan_slab_free mm/kasan/common.c:366 [inline]
  ____kasan_slab_free mm/kasan/common.c:328 [inline]
  __kasan_slab_free+0xe8/0x120 mm/kasan/common.c:374
  kasan_slab_free include/linux/kasan.h:235 [inline]
  slab_free_hook mm/slub.c:1723 [inline]
  slab_free_freelist_hook mm/slub.c:1749 [inline]
  slab_free mm/slub.c:3513 [inline]
  kfree+0xac/0x2d0 mm/slub.c:4561
  selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
  security_tun_dev_free_security+0x4f/0x90 security/security.c:2342
  tun_set_iff.constprop.66+0x9f9/0x1d10 drivers/net/tun.c:2782
  __tun_chr_ioctl+0xdf8/0x2870 drivers/net/tun.c:3026
  tun_chr_ioctl+0x2f/0x40 drivers/net/tun.c:3311
  vfs_ioctl fs/ioctl.c:51 [inline]
  __do_sys_ioctl fs/ioctl.c:874 [inline]
  __se_sys_ioctl fs/ioctl.c:860 [inline]
  __x64_sys_ioctl+0x19d/0x220 fs/ioctl.c:860
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x3a/0x80 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x44/0xae

The buggy address belongs to the object at ffff888066b87370
  which belongs to the cache kmalloc-8 of size 8
The buggy address is located 0 bytes inside of
  8-byte region [ffff888066b87370, ffff888066b87378)
The buggy address belongs to the page:
page:0000000003b0639d refcount:1 mapcount:0 mapping:0000000000000000 
index:0x0 pfn:0x66b87
flags: 0xfffffc0000200(slab|node=0|zone=1|lastcpupid=0x1fffff)
raw: 000fffffc0000200 dead000000000100 dead000000000122 ffff888100042280
raw: 0000000000000000 0000000080660066 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
  ffff888066b87200: fc fb fc fc fc fc 00 fc fc fc fc fa fc fc fc fc
  ffff888066b87280: fa fc fc fc fc fa fc fc fc fc fb fc fc fc fc fa
 >ffff888066b87300: fc fc fc fc 00 fc fc fc fc fb fc fc fc fc fa fc
                                                              ^
  ffff888066b87380: fc fc fc fa fc fc fc fc 00 fc fc fc fc fa fc fc
  ffff888066b87400: fc fc fa fc fc fc fc fa fc fc fc fc fa fc fc fc
==================================================================

>
> And why can't security_tun_dev_free_security() handle a NULL value?

security_tun_dev_free_security() could be modified to handle the NULL value.

George

>
> thanks,
>
> greg k-h