MIME-Version: 1.0
References: <20211208171113.22089-1-jose.exposito89@gmail.com>
In-Reply-To: <20211208171113.22089-1-jose.exposito89@gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 8 Dec 2021 09:33:14 -0800
Message-ID: <CAP-5=fUAR9uSAQGkukqafkoX+jz1fE8f-ziU5WeG59XT53jMWw@mail.gmail.com>
Subject: Re: [PATCH] perf util: Fix use after free in metric__new
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, ak@linux.intel.com,
        john.garry@huawei.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 8, 2021 at 9:11 AM Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gma=
il.com> wrote:
>
> Addresses-Coverity-ID: 1494000
> Signed-off-by: Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmail.com>

Acked-by: Ian Rogers <irogers@google,com>

This can only happen in the ENOMEM case, but it is a good fix.

Fixes: b85a4d61d302 (perf metric: Allow modifiers on metrics)

Thanks,
Ian

> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.=
c
> index fffe02aae3ed..4d2fed3aefd1 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -209,8 +209,8 @@ static struct metric *metric__new(const struct pmu_ev=
ent *pe,
>         m->metric_name =3D pe->metric_name;
>         m->modifier =3D modifier ? strdup(modifier) : NULL;
>         if (modifier && !m->modifier) {
> -               free(m);
>                 expr__ctx_free(m->pctx);
> +               free(m);
>                 return NULL;
>         }
>         m->metric_expr =3D pe->metric_expr;
> --
> 2.25.1
>