Message-ID: <a70956e1c4da10603e29087e893cbae62ce82631.camel@linux.intel.com>
Subject: Re: [PATCH RESEND V2 3/6] platform/x86/intel: Move intel_pmt from
 MFD to Auxiliary Bus
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     lee.jones@linaro.org, hdegoede@redhat.com, bhelgaas@google.com,
        andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
        mgross@linux.intel.com, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org,
        Mark Gross <markgross@kernel.org>
Date:   Wed, 08 Dec 2021 11:09:48 -0800
In-Reply-To: <YbD1NsYHbU8FvtTN@kroah.com>
References: <20211208015015.891275-1-david.e.box@linux.intel.com>
         <20211208015015.891275-4-david.e.box@linux.intel.com>
         <YbDbql39x7Kw6iAC@kroah.com>
         <7e78e6311cb0d261892f7361a1ef10130436f358.camel@linux.intel.com>
         <YbD1NsYHbU8FvtTN@kroah.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-12-08 at 19:11 +0100, Greg KH wrote:
> On Wed, Dec 08, 2021 at 09:47:26AM -0800, David E. Box wrote:
> > On Wed, 2021-12-08 at 17:22 +0100, Greg KH wrote:
> > > On Tue, Dec 07, 2021 at 05:50:12PM -0800, David E. Box wrote:
> > > > +static struct pci_driver intel_vsec_pci_driver = {
> > > > +       .name = "intel_vsec",
> > > > +       .id_table = intel_vsec_pci_ids,
> > > > +       .probe = intel_vsec_pci_probe,
> > > > +};
> > > 
> > > So when the PCI device is removed from the system you leak resources and
> > > have dangling devices?
> > 
> > No.
> > 
> > > 
> > > Why no PCI remove driver callback?
> > 
> > After probe all resources are device managed. There's nothing to explicitly clean up. When the
> > PCI
> > device is removed, all aux devices are automatically removed. This is the case for the SDSi
> > driver
> > as well.
> 
> Where is the "automatic cleanup" happening?  As this pci driver is bound
> to the PCI device, when the device is removed, what is called in this
> driver to remove the resources allocated in the probe callback?
> 
> confused,

devm_add_action_or_reset(&pdev->dev, intel_vsec_remove_aux, auxdev)

intel_vsec_remove_aux() gets called when the PCI device is removed. It calls auxiliary_device_unit()
which in turn calls the auxdev release() function that cleans up resources.

When the auxdev is removed, all resources that were dev_m added by the SDSi driver are released too
which is why it has no remove() either. I'll add the tests that check this.

David

> 
> greg k-h