MIME-Version: 1.0
References: <20211208192009.322190-1-ariel.dalessandro@collabora.com> <20211208192009.322190-6-ariel.dalessandro@collabora.com>
In-Reply-To: <20211208192009.322190-6-ariel.dalessandro@collabora.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 8 Dec 2021 16:26:50 -0300
Message-ID: <CAOMZO5CnzVm83yHbzg2OD8HqNEV0-sXduDH9zPHctRy2i9ErDA@mail.gmail.com>
Subject: Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2
 IMX6ULZ SystemMaster
To:     "Ariel D'Alessandro" <ariel.dalessandro@collabora.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
        ioana.ciornei@nxp.com, jagan@amarulasolutions.com,
        kernel@pengutronix.de, krzk@kernel.org, linux-imx@nxp.com,
        matt@traverse.com.au, matteo.lisi@engicam.com,
        meenakshi.aggarwal@nxp.com, michael@amarulasolutions.com,
        nathan@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        shawnguo@kernel.org, tharvey@gateworks.com, robh@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 8, 2021 at 4:21 PM Ariel D'Alessandro
<ariel.dalessandro@collabora.com> wrote:
>
> From: Michael Trimarchi <michael@amarulasolutions.com>
>
> Add DTS of BSH SMM-M2 SystemMaster.
>
> This version comes with:
> - 128 MiB DDR3 RAM
> - 256 MiB Nand
> - wifi
> - bluetooth
>
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  arch/arm/boot/dts/Makefile               |   3 +-
>  arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 146 +++++++++++++++++++++++

There is a typo in the Subject: it says imx8ulz, but it should be
imx6ulz instead.

> +/ {
> +       model = "BSH SMM M2";
> +       compatible = "bsh,imx6ulz-bsh-smm-m2", "fsl,imx6ull";

Shouldn't "fsl,imx6ulz" also be added here like it is done in
imx6ulz-14x14-evk.dts?