Date: Mon, 22 Jan 2007 11:56:24 -0800
From: Andrew Morton <akpm@osdl.org>
To: Ben Dooks <ben@trinity.fluff.org>
Cc: rpurdie@rpsys.net, ben-linux@fluff.org, linux-kernel@vger.kernel.org
Subject: Re: LEDS: S3C24XX generate name if none given
Message-Id: <20070122115624.2aefb97c.akpm@osdl.org>
In-Reply-To: <20070115154221.GH11889@trinity.fluff.org>
References: <20070115122654.GA25047@home.fluff.org>
	<1168868669.5860.49.camel@localhost.localdomain>
	<20070115154221.GH11889@trinity.fluff.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1041
Lines: 27

> On Mon, 15 Jan 2007 15:42:21 +0000 Ben Dooks <ben@trinity.fluff.org> wrote:
> On Mon, Jan 15, 2007 at 01:44:28PM +0000, Richard Purdie wrote:
> > On Mon, 2007-01-15 at 12:26 +0000, Ben Dooks wrote:
> > > Generate a name if none is passed to the S3C24XX GPIO LED driver.

Wouldn't it be better to fix the callers to consistently pass in a name
rather than hacking around fixing stuff up in the callee?

> +	/* create name if we were not passed one */
> +
> +	if (led->cdev.name == NULL) {
> +		char name[64];
> +
> +		snprintf(name, sizeof(name), "%s.%d",  dev->name, dev->id);
> +		led->cdev.name = kstrdup(name);
> +	}
> +

Take a peek at kasprintf() ;)

Please include full-and-fresh changelog in each iteration of a patch, so
poor patch-takers don't have to go making one up for you, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/