Date:   Wed, 8 Dec 2021 20:21:25 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Cc:     alsa-devel@alsa-project.org, Vijendar.Mukunda@amd.com,
        Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: max98357a: Add mixer control to mute/unmute speaker
Message-ID: <YbETxcwa83U8WXTO@sirena.org.uk>
References: <20211208185850.1555996-1-AjitKumar.Pandey@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Nru0qQ3jsfsVj9cp"
Content-Disposition: inline
In-Reply-To: <20211208185850.1555996-1-AjitKumar.Pandey@amd.com>
Precedence: bulk


--Nru0qQ3jsfsVj9cp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 09, 2021 at 12:28:49AM +0530, Ajit Kumar Pandey wrote:

> +static int speaker_mute_put(struct snd_kcontrol *kcontrol,
> +			    struct snd_ctl_elem_value *ucontrol)
> +{
> +	struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
> +	struct max98357a_priv *max98357a = snd_soc_component_get_drvdata(component);
> +	int mode = ucontrol->value.enumerated.item[0];
> +
> +	max98357a->sdmode_switch = mode;
> +	gpiod_set_value_cansleep(max98357a->sdmode, mode);
> +	dev_dbg(component->dev, "set sdmode to %d", mode);

This looks like it should just be a DAPM widget - it's just a generic
GPIO control, there's no connection with the CODEC that I can see so it
definitely shouldn't be in the CODEC driver.  Often trivial stuff like
this is done in the machine driver, though the simple-amplifier driver
is probably a good fit here.

--Nru0qQ3jsfsVj9cp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGxE8UACgkQJNaLcl1U
h9Bjfgf+Idtlzi+zebn2o/I5PxidR71VIpfcfx3wi84zBF17C35koKEMCxLD+lYg
ggmn+Av7y0UxKOlJH2dMbGjHppbIGObSXXfwZz4DW/EvkIB3txbM0P+g+3kZlC5H
Bb9UvdzotaSXfV5KdKA5s0Uv1ZPaCzBLbCJ5gHNR7l9avwKF1eNjHNjBUZnGd807
LnirgNeMo0WCM1XcgOWQIUcY8HvD7Z1Vf1UudXFhiRMOXZN5UpDbFImqxcTe666r
QL4+jcqKchLQ+7fgoizslapoNoGz6qPRV4P2usgG5DNh9fMaVO8cF0/skeG8ukq9
MhlVPlul0sAjPKYgPoteGWAJOku/2w==
=Ysd+
-----END PGP SIGNATURE-----

--Nru0qQ3jsfsVj9cp--