Date:   Wed, 8 Dec 2021 17:14:06 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Tao Zhou <tao.zhou@linux.dev>, Ingo Molnar <mingo@redhat.com>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 03/14] rtla: Add osnoise tool
Message-ID: <20211208171406.353bc200@gandalf.local.home>
In-Reply-To: <9944378d-456f-79a5-2dbf-30dbbbc94522@kernel.org>
References: <cover.1638182284.git.bristot@kernel.org>
        <ffb7f1b1e8cc42fc8ec52f1a89fdd2ca0d70c36e.1638182284.git.bristot@kernel.org>
        <YaZEzvzp5jkRyLEJ@geo.homenetwork>
        <9944378d-456f-79a5-2dbf-30dbbbc94522@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2 Dec 2021 16:18:53 +0100
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> >> +	if (!strcmp(context->orig_cpus, context->curr_cpus))
> >> +		goto out_done;
> >> +
> >> +	retval = write(context->cpus_fd, context->orig_cpus, strlen(context->orig_cpus));  
> > 
> > 'strlen(context->orig_cpus) + 1' for write size;
> >   
> >> +	if (retval < strlen(context->orig_cpus))  
> > 
> > Same here. Check 'strlen(context->orig_cpus) + 1'  
> 
> Fixed in v9.

And if you used the tracefs_instance_file_write() function, you would not
have had his bug ;-)

-- Steve