Date:   Wed, 8 Dec 2021 20:47:02 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Cedric Le Goater <clg@kaod.org>,
        xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Jon Mason <jdmason@kudzu.us>,
        Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>, linux-ntb@googlegroups.com
Subject: Re: [patch V2 02/31] genirq/msi: Add mutex for MSI list protection
Message-ID: <20211209004702.GL6385@nvidia.com>
References: <20211206210600.123171746@linutronix.de>
 <20211206210747.708877269@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210747.708877269@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IhnJsqHq/qBxb2jYgaHL8ooQrKSsvmcu/5qZaYYSkI20/1gw+Vhgb4bTPq0Q?=
 =?us-ascii?Q?Gf5pePMzGeQ24KGMZBiJpCEJxz/ZIzh1OuGqzUdmXbzstFa69j3LaDxh3+t0?=
 =?us-ascii?Q?vgONaX4CD6WjGj/Fq2q2xAPeOhdWrwNDKAxtkUYGGHtzKJIGw3zhAtdDMtQC?=
 =?us-ascii?Q?eclDzq+d9u2mG1xK7lU8Pxt7sI8eU+SASWJqMBKq5Te1lFe6w4wVohWSvD2N?=
 =?us-ascii?Q?jUGY3+5C9SVj5kIOKVzae0bl5IsxexpreTxiTdnI1kRF9ryqBDn4aTPdkhjD?=
 =?us-ascii?Q?/GhZKFADlqN2s+pGVjsECEftQ6C4c8AHpgbbC5yVha+BBmLAPQ+9qMAtf4H8?=
 =?us-ascii?Q?OAO0e7dC4+3ufqhiPL4fNhOKNeyOcJ5ESolsTUGPeZwz96y7AhLY+/GQISky?=
 =?us-ascii?Q?ccTMEckAUa32KpKtvjDI/Fy7Pl4CX8jCrNhYemgPyScO6sWRBudpEXw9WqQq?=
 =?us-ascii?Q?naK1/qlJnOjdPPkelzQ7G9X1YlZwONYp17EVlHoTkThOxTuEtWWFmNdGp/9O?=
 =?us-ascii?Q?0HacfLg1Um+ONjBNXifqasbG+cH6uZabPuKy/C9b4Adc5e3TnEs8+lSWDEyO?=
 =?us-ascii?Q?XhN0E80UAN3WFCdvvCwiRugmwmSf80FtSClBkptSiKAdjnTFqC5hm0kBPocV?=
 =?us-ascii?Q?03UzVlKbg8F974AJaS7rRwjRwS/Tcrlae6dIIKJtX8+nXi1KRnkzyFuOKUCj?=
 =?us-ascii?Q?HPQt8N0SR/fW1ymFWkOkZcSzCAhjpeSZhqSSsrJDCbx4cPZZzwmHKpuPKfqE?=
 =?us-ascii?Q?Ih8+5bz1qqunPknmpHrkN1KNNHUq8U8HfRzccfwA5FameF4auKSkDj/b2BrX?=
 =?us-ascii?Q?yJ1OhuRLCq1dIZBoQQL1yAN5BvSe+HDYBQLfAOaiSqxRISIAeU9dvaaqKm49?=
 =?us-ascii?Q?90Qd/ouNmreqYUHpyL2BcyInexO3UN7Q9EpqtHOV14rVySvGv86qj7InZtcd?=
 =?us-ascii?Q?t6JmlV8rmAOibM8JWOQOHvIPara1+aniVv/CXrNAGxrG8qMpIEerM8z8raa6?=
 =?us-ascii?Q?JzjXmya4nTNnvlXCciYfR8fXmepXn559k6Dsp+OndWi7EWDNmEqcSvkLP7Ve?=
 =?us-ascii?Q?ExhRvcFxpk9p9Ns5XSmfWf8Lav8kUt14BwGwIw7F0ezZyvLjjG5GBMW2LXCt?=
 =?us-ascii?Q?oD9I6XNdy69x0q/QI/embTs3L+aRC4DiUe2U/s5K4i+euts1oSKoTSVGhMPS?=
 =?us-ascii?Q?2V1NeBNrPVFwvOdTtMaWfpx+F0zyKGUxXLYJs2XGFVqnMyXbG+BIPkatNfmf?=
 =?us-ascii?Q?2wdCgOMRjlOaW1A2tIxYJtzCzrFOnFRnb5ZBRzjNEIT1Kiofyzq20g7wiC0V?=
 =?us-ascii?Q?3iQSmW7V1ujCl31IWixOw4ZpDdjo4pdKB7DLUFLIIf7rzKA5NfdLv6FDwCZL?=
 =?us-ascii?Q?8YdKjB6Lgrxy8GCodikahFQ6QGOXiVabTJ66GvS1H+ZBLuIMTPTHwpyUNswC?=
 =?us-ascii?Q?X6eCipMewdNRSYOXEhggOWegxVpyXupYaZUXhuqidW5JaxOm4MuKS9SKwT8M?=
 =?us-ascii?Q?uxRKJ+eQu/E0AcHd20qNEN03SYShxCbLV3Uo0O4B3M8zXh/mytjtq7OwLeKb?=
 =?us-ascii?Q?ijq7hSUr0nnjSFFapEI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c14e566-daaf-406c-77a3-08d9baad6afe
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 00:47:03.9305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mw9FYEpaoBsAeiwIYYxisGGhScNaHffggJWKK9TqDuFHAggnPKGHyOBgz/wnnSy4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5302
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 06, 2021 at 11:51:05PM +0100, Thomas Gleixner wrote:
> +++ b/kernel/irq/msi.c
> @@ -127,12 +127,37 @@ int msi_setup_device_data(struct device
>  		return -ENOMEM;
>  
>  	INIT_LIST_HEAD(&md->list);
> +	mutex_init(&md->mutex);
>  	dev->msi.data = md;
>  	devres_add(dev, md);
>  	return 0;
>  }
>  
>  /**
> + * msi_lock_descs - Lock the MSI descriptor storage of a device
> + * @dev:	Device to operate on
> + */
> +void msi_lock_descs(struct device *dev)
> +{
> +	if (WARN_ON_ONCE(!dev->msi.data))
> +		return;

Is this useful? Other places that call msi_lock_descs will continue on and deref
null dev->msi anyhow - is the dump from the WARN_ON that much better
than the oops from the null deref here:

> +	mutex_lock(&dev->msi.data->mutex);

?

Honestly, still a bit unclear on what the community consensus is for
using WARN_ON.

Jason