Subject: Re: [PATCH -next] io_uring: use timespec64_valid() to verify time
 value
To:     <axboe@kernel.dk>, <asml.silence@gmail.com>,
        <io-uring@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20211202064946.1424490-1-yebin10@huawei.com>
From:   yebin <yebin10@huawei.com>
Message-ID: <61B166D9.8070809@huawei.com>
Date:   Thu, 9 Dec 2021 10:15:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20211202064946.1424490-1-yebin10@huawei.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/12/2 14:49, Ye Bin wrote:
> It's better to use timespec64_valid() to verify time value.
>
> Fixes: 2087009c74d4("io_uring: validate timespec for timeout removals")
> Fixes: f6223ff79966("io_uring: Fix undefined-behaviour in io_issue_sqe")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
>   fs/io_uring.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 568729677e25..929ff732d6dc 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6151,7 +6151,7 @@ static int io_timeout_remove_prep(struct io_kiocb *req,
>   			return -EINVAL;
>   		if (get_timespec64(&tr->ts, u64_to_user_ptr(sqe->addr2)))
>   			return -EFAULT;
> -		if (tr->ts.tv_sec < 0 || tr->ts.tv_nsec < 0)
> +		if (!timespec64_valid(&tr->ts))
>   			return -EINVAL;
>   	} else if (tr->flags) {
>   		/* timeout removal doesn't support flags */
> @@ -6238,7 +6238,7 @@ static int io_timeout_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe,
>   	if (get_timespec64(&data->ts, u64_to_user_ptr(sqe->addr)))
>   		return -EFAULT;
>   
> -	if (data->ts.tv_sec < 0 || data->ts.tv_nsec < 0)
> +	if (!timespec64_valid(&data->ts))
>   		return -EINVAL;
>   
>   	data->mode = io_translate_timeout_mode(flags);
ping...