Date:   Thu, 9 Dec 2021 09:06:12 +0500
From:   Ameer Hamza <amhamza.mgc@gmail.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     kabel@kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
        f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: dsa: mv88e6xxx: error handling for serdes_power
 functions
Message-ID: <20211209040612.GA8939@hamza-OptiPlex-7040>
References: <20211208164042.6fbcddb1@thinkpad>
 <20211208155809.103089-1-amhamza.mgc@gmail.com>
 <20211208172820.1f273b3e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211208172820.1f273b3e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Precedence: bulk

On Wed, Dec 08, 2021 at 05:28:20PM -0800, Jakub Kicinski wrote:
> On Wed,  8 Dec 2021 20:58:09 +0500 Ameer Hamza wrote:
> > @@ -1507,7 +1510,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
> >  			    bool on)
> >  {
> >  	u8 cmode = chip->ports[port].cmode;
> > -	int err = 0;
> > +	int err;
> >  
> >  	if (port != 0 && port != 9 && port != 10)
> >  		return -EOPNOTSUPP;
> 
> This is on top of v1? It doesn't seem to apply, v1 was not merged.
Oh, sorry! Its not incremental but I think my repository was a
few commits old. Let me send the updated patch.

> Also can you please add Fixes tags?
Sure.