From:   Yihao Han <hanyihao@vivo.com>
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH v2] samples/bpf: xdpsock: fix swap.cocci warning
Date:   Thu,  9 Dec 2021 01:22:50 -0800
Message-Id: <20211209092250.56430-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jl7AZs48NRRGb3DlY6qsugZZKIgXLkTYYokHQ7LwU13fZMk7/+SGkpjq3MaX?=
 =?us-ascii?Q?j+9zm2iicIKMKEQAq3X/wUfq2Kmy8ubaCmFeg9bboy1ccytaPP+/9Z0Bqfti?=
 =?us-ascii?Q?izVu8GlucPT0JMfuoh50VhN9LHYLW1DdOQ0ldc6dtK5NQS1pi9uxLLrnqBHB?=
 =?us-ascii?Q?9khimlR2O7BtUwUwMxm/hsM+CjP1X/kmUrwAGUD9NuSQnWZmAY8zxWwHy/FW?=
 =?us-ascii?Q?zw33gGqdq3nUwVYHqCOAWEJcob+QDFXp0CHD0nzBvbUEK1IvFeXSZc/EJ5Bb?=
 =?us-ascii?Q?tUixEB7pWfH6XM22zyC0fyy4yuesmLvTz1S+ArQwyeTHHKDT7WWgBB8NX5BZ?=
 =?us-ascii?Q?e7tdKtZDaXA1GXBHUcVCe9Qrd2+9x3dokdF+8Oysz6Yi07yZAp9rT18FVwgi?=
 =?us-ascii?Q?7J8W2AbBHlWfmgmchDMxsYTcHSGmskFF6XYRyemD+jdE06PIyknpbKuCELok?=
 =?us-ascii?Q?JKYuMdsoWCo/0FVT4tXhprDiOEeywO4OBioAigM/3sfxo8xa2U4LcCCynLbt?=
 =?us-ascii?Q?a/ufR3zQxDfR9zFPu27f8+xZXy9AWy0155B/DPD9+vcfe4zeCl8aGlCDCWu7?=
 =?us-ascii?Q?s3KcDzsAvB7AnI1uVcxO7Qc17R7cBu98MJ7ycQD1VvmcHP7b8bG66u7SbD4p?=
 =?us-ascii?Q?S06plil6P4HlldOqw/7uR0IuMKm8wfsI2BfOZLHi/8FBchgrzL3WBKIbFGWo?=
 =?us-ascii?Q?coGpugDHHIFNZzfeuP5iQn/WHZlwPTkM8fFgmg8ySJ/3AlMIP9VPzJ19w4WA?=
 =?us-ascii?Q?bTxJKxP1cF2y5yakF4snOw4w+0TatDMCK0UE6vBQsNGXmk7xlbffRefoXIQ/?=
 =?us-ascii?Q?rQcdAOl51/z9+biJIxeDW31qbzL0/rbaOOKWEvd7WPqOOhQ482WI7XkZw7Kl?=
 =?us-ascii?Q?ak+cF/a4dhzsaWely33jZumzBdu8dwOHVMTnIHBkRCyCOG9FEHB3rde1ARZD?=
 =?us-ascii?Q?jvd9M1urGFDTkUI69pBlDAmSTLJXYAcBZA484ID4kVVwF+QSdBwQKzWmOrRt?=
 =?us-ascii?Q?OO2Hc+DKISLbM4I8EBbxcrWeNwyGZkJAteNLYIL0ThnTVndyxa3a2lP6tDfU?=
 =?us-ascii?Q?KOid1OqhDbU/cQIzijDNdZmKOSee1wCxGtEVzVd45njmo9cTyUVIgWis+FK4?=
 =?us-ascii?Q?c6e411Q5o9tk56umtT5gKFOiQ2ut1LGZQyv5Rbgx6sT1hjq1rMcn6cxgRFTO?=
 =?us-ascii?Q?oSmG9/yWv1TQ5XYXkupMemz0PjJOoKTHRxvrgdw2LFiEOm830pWSkRT+18bl?=
 =?us-ascii?Q?5Dokx5PKhXw45L7ep/OIBxDxZhA7uKe3kotJSStxvhuyhbZ34KR3slaj85ye?=
 =?us-ascii?Q?AIftJomqB0ffLEyNAzbhMYd7owccN8wC/f3c2azAj5XWfIdxtG47g3dAfLy9?=
 =?us-ascii?Q?irCD3++JrMhy3dFNLTKJ32W0huU9RFatWMNhy89c5mGz1qmV76AVRt9Ne5JQ?=
 =?us-ascii?Q?QGkNncgEBKhvcXdRD7kO2U9O3LjBhBZo0jcehAFE5Jwg7esj0KLUi59n2hCK?=
 =?us-ascii?Q?2gGrXl5KxzLFkiUdnXRw9Mhh4BJRr/DYUEhJpv+D+gioHfZR59YCsyWZY37J?=
 =?us-ascii?Q?jboFHMAcPIihDRMyS/YW6NKa6YcptSneIqA2KsJRmDoaKG7EOlovZuIKsP5V?=
 =?us-ascii?Q?jixVsZBY+6m5SNvlBQNF/HU=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c251d159-ad09-4fa3-7602-08d9baf5a1b9
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 09:23:59.4278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5DNSZJQJrFTrdrhEs4dvWvqIliiSai4V2FK6B8z3rn5K+85rtmfczhXe8vupEYB0Bmh27enX85VLR+Tnk9Zr8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB3486
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following swap.cocci warning:
./samples/bpf/xdpsock_user.c:528:22-23:
WARNING opportunity for swap()

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
Change log:
v2:
- Remove temp variable.
---
 samples/bpf/xsk_fwd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c
index 1cd97c84c337..db15323728c0 100644
--- a/samples/bpf/xsk_fwd.c
+++ b/samples/bpf/xsk_fwd.c
@@ -651,11 +651,8 @@ static void swap_mac_addresses(void *data)
 	struct ether_header *eth = (struct ether_header *)data;
 	struct ether_addr *src_addr = (struct ether_addr *)&eth->ether_shost;
 	struct ether_addr *dst_addr = (struct ether_addr *)&eth->ether_dhost;
-	struct ether_addr tmp;
 
-	tmp = *src_addr;
-	*src_addr = *dst_addr;
-	*dst_addr = tmp;
+	swap(*src_addr, *dst_addr);
 }
 
 static void *
-- 
2.17.1