From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 2/6] dt-bindings: net: lan966x: Extend with
 the analyzer interrupt
Thread-Topic: [PATCH net-next v3 2/6] dt-bindings: net: lan966x: Extend with
 the analyzer interrupt
Thread-Index: AQHX7OGhd+X5RJxwmEebfZUvbnLxIqwp/cOA
Date:   Thu, 9 Dec 2021 10:58:58 +0000
Message-ID: <20211209105857.n3mnmbnjom3f7rg3@skbuf>
References: <20211209094615.329379-1-horatiu.vultur@microchip.com>
 <20211209094615.329379-3-horatiu.vultur@microchip.com>
In-Reply-To: <20211209094615.329379-3-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q3ufzZfvicIbn+oYwBfEwLES4DPBahqn7W2Ud8PVsK87Imym5/FEb52UqAb5?=
 =?us-ascii?Q?N06b9s9qco3rp8xHlsAdGMhgJvf6CIM+ebkDrmOmFa+gSzqxpuR4O36e/KDt?=
 =?us-ascii?Q?IPvKNgGZ7MxOC3UQbKHW+wNG1SQ9pocbRpSI9SICiQh1vd3flC6f8dYNLBNN?=
 =?us-ascii?Q?cZP/7cnWfq0ai3lSZr/Jsy91JsWqJxAzA1aWBT17XxqK+67YSkqdblE+uyRF?=
 =?us-ascii?Q?kvw4273mqukBbwU8yGZzSJ2mkWK+kRTYQES95ZgxBuV1tlhcQStMHvJLRTqk?=
 =?us-ascii?Q?N3jxhVp60nW9eFjfCOUURgSzlKDjNBhUIkTDHfpor138VAyRFzKRz/6SHZv5?=
 =?us-ascii?Q?YnWItbz8vaMyQjEOib317EwuSHTBmRcZ5yI11yXMA68SiPOZZpjGjpy7b6D9?=
 =?us-ascii?Q?PDIY9xmxLPopXspipKPaizUm8v7h9RBpjc9DRKrePrMo3wKB3IUz+4uhZHnf?=
 =?us-ascii?Q?bJWpGKPaQolWyuVSF0lEPbBx6TuL9Mdon5J7KqPl9OG6/6bV8nrL9l3svqd8?=
 =?us-ascii?Q?PAo+vEgvH07R87LSGROv9n1LNeDPn+XlCrVyQn/sdKDuRwiQ97MxtDrI+S6E?=
 =?us-ascii?Q?acFOHZr1SBcR+6XUgrYBHHqOkQSfcZokEVOm1PFd4YQoOLNFZ5ya3lfSVPvV?=
 =?us-ascii?Q?Hfp8Qth1Y6+yu7NOxmWbrXxC6YmqsRP3C2ZTkAXks+vnIMEd48GIGpuIFWia?=
 =?us-ascii?Q?XgbqLrASz68rip0t3TKqxzNOwFbTe2IitqvS9Q/LX7qQxukDHYACIFPpWTp2?=
 =?us-ascii?Q?p5jsvrAyGHhzmylPC+9Fwhg0YfIrbme1vVKwsCdGSUP9OPusk2srKi38ehG6?=
 =?us-ascii?Q?s5EUmmX14s/zIcG284oOm/X8p7ji470o0sf/a7xMOzJHXELk3hEyiMcljzwV?=
 =?us-ascii?Q?bhlX2dRb7bcqPNeado4FkeK7/Uq5O152PjBtM8OUSnSaarV2RBtYLXSC2BPb?=
 =?us-ascii?Q?lvBfReBsxn5N4WqekJWzz0JnVrzfVE68qqyzCJpB+ALnM6HYLj1HxA6JUvSR?=
 =?us-ascii?Q?oEfs7mLrSnmhkgc4MIdNI5Nw+9mnqwkUcBG1KAiYxZQn8hwSIPuzfORObSD/?=
 =?us-ascii?Q?xUvOO7k4h0ShxxejIWnyQS8FZbtCVWFP49ZmWLhEMvnqezb5gvEFCaq2G0pV?=
 =?us-ascii?Q?zfnXPazOmYdjctBJVCA7A1yRwFZ9q0K1uhO12mPvV948v/wOPsMKxKiOarpa?=
 =?us-ascii?Q?MZQkAqROnRzIqEC/rBaaNoE5dyK3Xw9QnKwdIYwErT9d9W9hmH8uedu8/UWp?=
 =?us-ascii?Q?Ulu5tN80JbtSFPJzJIZk+B8F6urOSPHGnpYb0WG5VIbD+KjFFGEpSYzlW/xP?=
 =?us-ascii?Q?zt3xubF6YKnCsLBxi5OT4reJEUXzpaSryqCn93kiqPu9odBFW5NQkX+9Xle6?=
 =?us-ascii?Q?zUWR6t4Zd84dEUJP9olCCdv+It7h5Vrd67opfWUWEdHAbUIXropUM7kNKqBn?=
 =?us-ascii?Q?xmMlhqUi4er76d3yVBqT3DBO4CtwhfDPC32QJ+TjHyDW3iBezXKydDDwbGix?=
 =?us-ascii?Q?Q1+RA+haKc7KajEt+4fzR44rn9QavE7ODReniLW3aaPn475zzpnfI1WIF7a0?=
 =?us-ascii?Q?eJJPWHGCrU64k21y2se26TESYzA/819MZEVfgTlHpHmNAoGGoq6OTv3xUEi6?=
 =?us-ascii?Q?tE71bcBCvtkZz4YybHrpQ8s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1CEC80D0D41FAF45B57D2F73A9FC967B@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf8fa601-4bf7-4683-024d-08d9bb02e6e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 10:58:58.6781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A2KNsS+Iz4eIh6G4TZNLzQCQTu4DpBzgopxBNz3WrSJLi+PvUhNlgbNlu74YJ/WBKGVzbVqz5MRzSlSnlmfiSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4738
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 09, 2021 at 10:46:11AM +0100, Horatiu Vultur wrote:
> Extend dt-bindings for lan966x with analyzer interrupt.
> This interrupt can be generated for example when the HW learn/forgets
> an entry in the MAC table.
>=20
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Why don't you describe your hardware in the device tree all at once?
Doing it piece by piece means that every time when you add a new
functionality you need to be compatible with the absence of a certain
reg, interrupt etc.

>  .../devicetree/bindings/net/microchip,lan966x-switch.yaml       | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-swit=
ch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.ya=
ml
> index 5bee665d5fcf..e79e4e166ad8 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> @@ -37,12 +37,14 @@ properties:
>      items:
>        - description: register based extraction
>        - description: frame dma based extraction
> +      - description: analyzer interrupt
> =20
>    interrupt-names:
>      minItems: 1
>      items:
>        - const: xtr
>        - const: fdma
> +      - const: ana
> =20
>    resets:
>      items:
> --=20
> 2.33.0
>=