Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD31C433FE for ; Thu, 9 Dec 2021 11:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235873AbhLIMDR (ORCPT ); Thu, 9 Dec 2021 07:03:17 -0500 Received: from mga14.intel.com ([192.55.52.115]:49365 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233270AbhLIMDP (ORCPT ); Thu, 9 Dec 2021 07:03:15 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="238308050" X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="238308050" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 03:59:41 -0800 X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="503464127" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 03:59:39 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mvI4O-0044ax-JK; Thu, 09 Dec 2021 13:58:40 +0200 Date: Thu, 9 Dec 2021 13:58:40 +0200 From: Andy Shevchenko To: Marc Kleine-Budde , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment Message-ID: References: <20211202205855.76946-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202205855.76946-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > GPIO library does copy the of_node from the parent device of > the GPIO chip, there is no need to repeat this in the individual > drivers. Remove assignment here. > > For the details one may look into the of_gpio_dev_init() implementation. Marc, what do you think about this change? -- With Best Regards, Andy Shevchenko