From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jianhe@ambarella.com" <jianhe@ambarella.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: Fix incorrect status for control request
Thread-Topic: [PATCH] usb: cdnsp: Fix incorrect status for control request
Thread-Index: AQHX60t+MP74NKbCqkG7HRhxiNimOqwqCsQAgAAVavA=
Date:   Thu, 9 Dec 2021 12:57:31 +0000
Message-ID: <BYAPR07MB5381415E88BAAC945CB47A93DD709@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20211207091838.39572-1-pawell@gli-login.cadence.com>
 <20211209113408.GA5084@Peter>
In-Reply-To: <20211209113408.GA5084@Peter>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RpBAL+g/1CIweOe2oxUe6OdDgz66TcUm1T9W8LzlgtZDcCBlYlgVInQzpVG0?=
 =?us-ascii?Q?OXZH6ZaQuJaa8PXwtOJ95dk0QVXxIiq7yDNVh6AaAn5+qNHYENMDBHzaqYS5?=
 =?us-ascii?Q?rkSm+QO6K1Dx4YscNOTt3iq5ZVY4U1cmto9DCILOFmzSHkIfku1fpVnO8uXF?=
 =?us-ascii?Q?KBagh35fQBQ21Q5dFSuIElJXQcnVQbI50W/8VRe45qrwe+mWYYUOIJ/4a3c4?=
 =?us-ascii?Q?4NcBoXwBPsDbu8VOhPjElo63nIPJB5vYVZl9uobB1QuxCy/4MoVsImfso5rz?=
 =?us-ascii?Q?QDs83SEfuz1nhR9YO+IulUh8lqHn/9y3ZMLecqA4Ehm1qQ15dkR/85ssrW/D?=
 =?us-ascii?Q?39VGw2w+H6sU55jwRahEy8LiqDOlXJCAWHypkRMZHQSkwNukItwQpL4Xm/GW?=
 =?us-ascii?Q?ErIWCbIg0C84yqKAHJ8vIv/7jJLwA0v1Cq+vxqB5mqyvCnJdBWvE+HVf+PSe?=
 =?us-ascii?Q?j98tLiKG2h44URPtz8gRWU05lN6WIbyWSPioZw9mNy0o0NQyfe+kCVjuD0pR?=
 =?us-ascii?Q?1S1FPhjHKdBiC4Ky4zcFmkvlzCjKBPip839VrpoIDPTTVSI16RHcsKYEHg9x?=
 =?us-ascii?Q?QbjLzKFiQpFTu6/fZc1uszDpXa71fnoHxboxReNwiI0jlsmxQszsO8ItrHeO?=
 =?us-ascii?Q?SOgaXFn6T9P4zYpKU9jWsVxgqLIiOlp3oCbPQAwK3vlTbbIS72spukXWNqdn?=
 =?us-ascii?Q?u60orqHhvqjeUpa+1pma5mHTDWB6tNXJi6WbvYK+odXylokthYzR9rgnrvbG?=
 =?us-ascii?Q?VOqydueBcyNyJZ9seFCNoXePM9LOUANG3vwM1B351xOPXZuyIbigDrTV8N6A?=
 =?us-ascii?Q?JoPVvdknkjoCUcfoNkDHYgCgLTwLhwQ7Wigs5z5MHxVaoZsk3ceHyZdkpdRI?=
 =?us-ascii?Q?rQCqT+9wUQQ++m60TjwwKI1vODDXQGy+WdBjAUca2BPF2XtxdR8yNdCebFbp?=
 =?us-ascii?Q?ueuSagCb+v7k9qfGcSBoIZVaoVIP3HvpsAdbu2itp0AEr2hK4dlIIHrxoGrt?=
 =?us-ascii?Q?JOaIH8SFO416GmlcRws9EhXWBjusCr5qLjUDlj1lkLCOunWcJ9wJFPFK9jil?=
 =?us-ascii?Q?8b3Zt6mTPZYAM8B7LZM0l+h73Hi0gUfDgKl/q0o8cOwJFnvk5WzFvvvP5ovP?=
 =?us-ascii?Q?4o0q2MQ88gNHXTrQ/AzF8ELjqjO0sGPu3zJP7UrBLDAmu+QTtUVWH1W52tDc?=
 =?us-ascii?Q?F6OmXwQfk1A8zoKPOsaWjqdmvn68wmNKgzLkt9Km6Ebc+0vaJ0ROkefYS4I6?=
 =?us-ascii?Q?0U7nitQ91MdDTCp1o7a5CKBqzWh4f4UFVzBCdCPmRTSl0d0gXuTJY+CDEWxQ?=
 =?us-ascii?Q?nuTqUD0/HSbPPmFl7q4bUzcsa5qsBSVgq6SMGMOyrrzgwHKhoWlx6mVJeswU?=
 =?us-ascii?Q?3hzXtizBdXS9Skh9TOtvVo+QSd04ss0MhBCog3IZjIs2kFdswQpeK/ka6R4g?=
 =?us-ascii?Q?5e56S/h7Sxejj1Ss/f0MwMYlDcTAdLBrpuw8ARN3p81aHzh871nVQcfoFX9H?=
 =?us-ascii?Q?DjzEP3KCRinn1j402KdKDiuvU8L7MQsfs3Llu/yqC7Zg5Ij/AKQ5wMYzLtX1?=
 =?us-ascii?Q?dLkeQ215TFfvNPVwQRKW4QzYbdNB1S37ziROktY3CBtxksUL7Mb0CTCj1jXg?=
 =?us-ascii?Q?GalpQ4kHjdNAf8UgCzFtz38nupaB/tpijfDsRNLYajUh+0fLiGmRwY3uDKeS?=
 =?us-ascii?Q?IdGwsA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5b72416-15c6-42be-46ee-08d9bb1376bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 12:57:31.9104
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 53OJu4v0RzwAQsXGIKC2RnY642ewfhokf1EQHd4s8sMtVuZ2EJFp5kpWPQ7rN2NoagYYjGmcFUNjlZ0OrZugmFLPG2S+uFgbS/dG6m7IAFo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4791
X-Proofpoint-GUID: xczO3D563VvqvvKj0k9xHZGE2tZ9vFPv
X-Proofpoint-ORIG-GUID: xczO3D563VvqvvKj0k9xHZGE2tZ9vFPv
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-09_04,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 clxscore=1015
 adultscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=734
 suspectscore=0 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112090072
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> From: Pawel Laszczak <pawell@cadence.com>
>>
>> Patch fixes incorrect status for control request.
>> Without this fix all usb_request objects were returned to upper drivers
>> with usb_reqest->status field set to -EINPROGRESS.
>>
>> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP =
DRD Driver")
>> Reported-by: Ken (Jian) He <jianhe@ambarella.com>
>> cc: <stable@vger.kernel.org>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/cdnsp-ring.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ri=
ng.c
>> index 1b1438457fb0..e8f5ecbb5c75 100644
>> --- a/drivers/usb/cdns3/cdnsp-ring.c
>> +++ b/drivers/usb/cdns3/cdnsp-ring.c
>> @@ -1029,6 +1029,8 @@ static void cdnsp_process_ctrl_td(struct cdnsp_dev=
ice *pdev,
>>  		return;
>>  	}
>>
>> +	*status =3D 0;
>> +
>>  	cdnsp_finish_td(pdev, td, event, pep, status);
>>  }
>>
>> --
>I think you may move *status =3D 0 at the beginning of
>cdnsp_process_ctrl_td in case you would like to handle some error
>conditions during this function.

I don't predict any other status code for control request in this place.
I wanted to set this status only once after completion status stage. It was=
 the reason why I put this
statement at the end of function.

--

Regards
Pawel Laszczak