Subject: Re: [PATCH] libceph, ceph: potential dereference of null pointer
To:     Jeff Layton <jlayton@kernel.org>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>, idryomov@gmail.com,
        davem@davemloft.net, kuba@kernel.org
Cc:     ceph-devel@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211209025038.2028112-1-jiasheng@iscas.ac.cn>
 <2a79206d3472b279079fbef5c9507f8805061c47.camel@kernel.org>
From:   Xiubo Li <xiubli@redhat.com>
Message-ID: <b01fa648-b0fe-c493-f45a-4ea23ae0f06e@redhat.com>
Date:   Thu, 9 Dec 2021 20:59:13 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <2a79206d3472b279079fbef5c9507f8805061c47.camel@kernel.org>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 12/9/21 7:20 PM, Jeff Layton wrote:
> On Thu, 2021-12-09 at 10:50 +0800, Jiasheng Jiang wrote:
>> The return value of kzalloc() needs to be checked.
>> To avoid use of null pointer in case of the failure of alloc.
>>
>> Fixes: 3d14c5d2b6e1 ("ceph: factor out libceph from Ceph file system")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> ---
>>   net/ceph/osd_client.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
>> index ff8624a7c964..3203e8a34370 100644
>> --- a/net/ceph/osd_client.c
>> +++ b/net/ceph/osd_client.c
>> @@ -1234,6 +1234,8 @@ static struct ceph_osd *create_osd(struct ceph_osd_client *osdc, int onum)
>>   	WARN_ON(onum == CEPH_HOMELESS_OSD);
>>   
>>   	osd = kzalloc(sizeof(*osd), GFP_NOIO | __GFP_NOFAIL);
>> +	if (!osd)
>> +		return NULL;
>>   	osd_init(osd);
>>   	osd->o_osdc = osdc;
>>   	osd->o_osd = onum;
> __GFP_NOFAIL should ensure that it never returns NULL, right?

Yeah, from the comment, it make no sense to test for failure here:


204? * %__GFP_NOFAIL: The VM implementation _must_ retry infinitely: the 
caller
205? * cannot handle allocation failures. The allocation could block
206? * indefinitely but will never return with failure. Testing for
207? * failure is pointless.
208? * New users should be evaluated carefully (and the flag should be
209? * used only when there is no reasonable failure policy) but it is
210? * definitely preferable to use the flag rather than opencode endless
211? * loop around allocator.
212? * Using this flag for costly allocations is _highly_ discouraged.
213? */


> Also, if you're going to fix this up to handle that error then you
> probably also need to fix lookup_create_osd to handle a NULL return from
> create_osd as well.