Subject: Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2
 IMX6ULZ SystemMaster
To:     Fabio Estevam <festevam@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
        ioana.ciornei@nxp.com, jagan@amarulasolutions.com,
        kernel@pengutronix.de, krzk@kernel.org, linux-imx@nxp.com,
        matt@traverse.com.au, matteo.lisi@engicam.com,
        meenakshi.aggarwal@nxp.com, michael@amarulasolutions.com,
        nathan@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        shawnguo@kernel.org, tharvey@gateworks.com, robh@kernel.org
References: <20211208192009.322190-1-ariel.dalessandro@collabora.com>
 <20211208192009.322190-6-ariel.dalessandro@collabora.com>
 <CAOMZO5CnzVm83yHbzg2OD8HqNEV0-sXduDH9zPHctRy2i9ErDA@mail.gmail.com>
From:   Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Message-ID: <078e6466-121e-1f1d-625b-7a0ffa684501@collabora.com>
Date:   Thu, 9 Dec 2021 10:36:31 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAOMZO5CnzVm83yHbzg2OD8HqNEV0-sXduDH9zPHctRy2i9ErDA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Fabio,

On 12/8/21 4:26 PM, Fabio Estevam wrote:
> On Wed, Dec 8, 2021 at 4:21 PM Ariel D'Alessandro
> <ariel.dalessandro@collabora.com> wrote:
>>
>> From: Michael Trimarchi <michael@amarulasolutions.com>
>>
>> Add DTS of BSH SMM-M2 SystemMaster.
>>
>> This version comes with:
>> - 128 MiB DDR3 RAM
>> - 256 MiB Nand
>> - wifi
>> - bluetooth
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>> ---
>>  arch/arm/boot/dts/Makefile               |   3 +-
>>  arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 146 +++++++++++++++++++++++
> 
> There is a typo in the Subject: it says imx8ulz, but it should be
> imx6ulz instead.

Ah, you're right. Will fix in v4.

> 
>> +/ {
>> +       model = "BSH SMM M2";
>> +       compatible = "bsh,imx6ulz-bsh-smm-m2", "fsl,imx6ull";
> 
> Shouldn't "fsl,imx6ulz" also be added here like it is done in
> imx6ulz-14x14-evk.dts?

Yes, it should. Will fix in v4.

Thanks a lot,
Ariel