From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 5/6] net: lan966x: Add vlan support
Thread-Topic: [PATCH net-next v3 5/6] net: lan966x: Add vlan support
Thread-Index: AQHX7OGlYEp5PrNq7UKGxDy/7sGvF6wqMDMA
Date:   Thu, 9 Dec 2021 13:59:28 +0000
Message-ID: <20211209135928.25myffd3xzcnmndl@skbuf>
References: <20211209094615.329379-1-horatiu.vultur@microchip.com>
 <20211209094615.329379-6-horatiu.vultur@microchip.com>
In-Reply-To: <20211209094615.329379-6-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?77/834Y473qxC2RTRWjsXLzNY3zznTyN/x/679iTYh+V4NRSTSM+oL7+TTjK?=
 =?us-ascii?Q?wj1Z52COQBsOAFM0rWQ2xJA+09EaGFQgxfLNfcnnKB4g2nZ+uDLU9ZBM1hPW?=
 =?us-ascii?Q?Pq49AoPfzrEtGrTRXWblaNT8WOopKS0LWue98CkcXMys2c3XbQ6nGJVWZswR?=
 =?us-ascii?Q?xO5Q4inUD9D/lisSjKRcGAcahAzexSBJycw0c9NgqQKQjLAwcdG8sBG85iIy?=
 =?us-ascii?Q?vFD0uMAcsvKzqWIoG5U7qoNc4Em+c2pUDRDgLR4oZphU+tcJDCO0+sv4+hRM?=
 =?us-ascii?Q?jAtM/KMCelReQQ7HlSqftaszG09S5nnPyhJYA2Uo4L+RYiGbBPzUIUsu6FHS?=
 =?us-ascii?Q?NXULPa0I3ktMf6J4yg/W8mxv3fDqX4ukpyqOJZSsgYcVSm+itIKxQOkxPwmA?=
 =?us-ascii?Q?g7KYbdAKDZEaoD/WhVM/UXUaNidYSdojFdOrHKofStyYQWGeV+00634lvl65?=
 =?us-ascii?Q?PV1y8WRhkeNv8ZuL1m1bxA5vfCRekCm4Gll8HNHFIDkQFIbR6QQ2rk1pBiMd?=
 =?us-ascii?Q?EiNDuo0L73dyH+BKR7Iaizp8/23OfCBAvjD5ymVfLo22SUdRZx77oOr5vNmg?=
 =?us-ascii?Q?JpAlg0fi6lyaGDNJ284KfZoo2dLLh3E3qxL5zOZCA6CGEBdR6urIkdBXkLYK?=
 =?us-ascii?Q?V6itMLB6lPklW4o5HDMNx/OFSJ6lYPh08sBffp3+LXMuB6mEoOD3WHXXUvGR?=
 =?us-ascii?Q?jVgJ0kmW+r0rC8uutXXnBGXAQi/dEQubR8wgwLTmEQCAVcuygNzK7zeouOge?=
 =?us-ascii?Q?y5OCHKKDPKljU6y+V6ckM/IPCqucGc01njir5PYssG2ZaFmv100MgDa7ydgF?=
 =?us-ascii?Q?sQx4LzI5B2lo7nEpsO6I239trvzM/9xDEMkfg1/qyzZ08DJERB/n2p8D8wgV?=
 =?us-ascii?Q?WSbB/OhzCGfBCiFxE8LkRYipOloM6xilX3Qifk60Vz9MrL+QuL0HWBWs/BbW?=
 =?us-ascii?Q?iat8w5AZarrDJQwNICBvRxmZSJJH9Nsw67kZogWTbPIYwz8txEiD0OECwBqM?=
 =?us-ascii?Q?WJSeuqkwakKVaRuDZhnl2WBRoYDd9DUeMSneU2/SMMED6ZkR7Rf2y/0/6QrN?=
 =?us-ascii?Q?o8jqxigyr4bC0PhcKHrEQ3jqpT3Fjnu4n8ZRE4p0ZKI+EJrkmZVTPl1Bsarq?=
 =?us-ascii?Q?RA9WcvYw69dCSq2HEhuiIwM5rEa4luT94MnRjDR7H0UCZwynds/QgKOh35UO?=
 =?us-ascii?Q?+ld8cgT6onFqDsltFbl+qKtNPqt+IcjB2fyM3Fp2RsW74CDm1nD3fOsiiD5J?=
 =?us-ascii?Q?Im5U6OsT39LIONK67K9k8QAkFphe9QfhjwNCfM74sQ1OOpWXy7hLiF5fyAqX?=
 =?us-ascii?Q?pq332iV1wIMyu2nwsBDUGkGv0oo6WsoPsbpvembKBb47MaFmpk27MYGxJ3Oh?=
 =?us-ascii?Q?HtAFy3MBr/zp8PhTaWVajkcykikjNuoSvBWDxQ5WF5y6MsU3EfBCz6S6d/DC?=
 =?us-ascii?Q?yTomOVi6+SMHbCC2sB/ktxTfXPjhe+A6VOdvQmDQkaV+tIKrQuP6WWHYZsRz?=
 =?us-ascii?Q?8s56x6jRDqfarErraKqSAaGutNTVvYd2mngQEkzwsvlJLXzM29McEgo8KkQQ?=
 =?us-ascii?Q?x0yCdW0ymVygxJVW5Z+fciMHUxRB6OR4UZtZNsJX42MQQUEHdI/9fX+0sY/W?=
 =?us-ascii?Q?oTbW1HEqkI4t+JtJfIn6U8U=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <69A8819DF5FA2F489BD10B71AE9DCCFA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23b74328-4ec1-4125-6800-08d9bb1c1e3b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 13:59:28.9264
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XGNO0pKfYs6f2KNPe500aMNoCRBE3e4//kucNGl1bgK2W1u+NMYORBJAIsYvQ97V9vrYvaFUMmvsYeLoGIhkZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5891
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 09, 2021 at 10:46:14AM +0100, Horatiu Vultur wrote:
> +int lan966x_vlan_port_set_vid(struct lan966x_port *port, u16 vid,
> +			      bool pvid, bool untagged)
> +{
> +	struct lan966x *lan966x =3D port->lan966x;
> +
> +	/* Egress vlan classification */
> +	if (untagged && port->vid !=3D vid) {
> +		if (port->vid) {
> +			dev_err(lan966x->dev,
> +				"Port already has a native VLAN: %d\n",
> +				port->vid);
> +			return -EBUSY;

Are you interested in supporting the use case from 0da1a1c48911 ("net:
mscc: ocelot: allow a config where all bridge VLANs are egress-untagged")?
Because it would be good if the driver was structured that way from the
get-go instead of patching it later.

> +		}
> +		port->vid =3D vid;
> +	}
> +
> +	/* Default ingress vlan classification */
> +	if (pvid)
> +		port->pvid =3D vid;
> +
> +	return 0;
> +}=