Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF61C4332F for ; Thu, 9 Dec 2021 14:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238349AbhLIOK6 (ORCPT ); Thu, 9 Dec 2021 09:10:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238298AbhLIOK5 (ORCPT ); Thu, 9 Dec 2021 09:10:57 -0500 Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53772C061746 for ; Thu, 9 Dec 2021 06:07:24 -0800 (PST) Received: by mail-vk1-xa2e.google.com with SMTP id 70so3849434vkx.7 for ; Thu, 09 Dec 2021 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=aOiyKQmystL558bO5VkHIM1ncICMWoc5eViBcWRY0xc=; b=GCUVV7TKAKr/xN0Rr3byEbzMFdnQ1aFeK13+eNVK8yteo6J4gqmeN54QMkQhx2Q0y9 xVtpIQL95ZHcwa5mLIAAs6Gw5QXVXVF12bg4SXgcakyg+6nNCqupHXNSPyju1nS9myvq yqihwmrHfVzbmjZVogciMkgx5DBtuhuMInQbled+yazrL2loG4zbzV8SrfF+/FJNQbXr SN9HsXL/OWCNrg9iVO3dKxRAYp5utW+ef8IJ/BjOllbHcwUF3FaS4x3+zRkfW3PWKV84 J4flmCFyLN/Ft+Mie0DUYtPdKLUIZketPdTyEUPyaONQDYozj3ZgMmiUVAuQqAMvEwkg AWbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=aOiyKQmystL558bO5VkHIM1ncICMWoc5eViBcWRY0xc=; b=pe9kzGc/cBEPBBJhrcEeyP0PZ9oNIa+cE7dnzWMbesCrkGnS8rSdPqiR5ExdTx4K4R PDMJgEWlaUKsnYUmFKENEsT8hIdGUa9COBrmK70Z2nSnw6+CJIju0Xdogk0w5sbWJfpy v9jI+8b30bzbC/uuRDqGCzjKnN3UKVsPJ6EtFghBuICzgt5wayFSRiWxR1p7XveOf6zn MqV4m+A57dq7QyeT1AFBKG+mMyycepFkNW3tH86fjOvjbL6nuwElFgzPxxE3qRnqPfDV 38B4G/NtOKzPSl2sqtTvUKSZSApXXzKbIJrXtXdUsD9XhK8TxQVTexJTlx0j6oBzzM5m nFjw== X-Gm-Message-State: AOAM531EEv1Nf4p2hhsaj5AkeaLy7Vsqj73aNIYtrjOgb3kJF8nfICFX UuC19hTW7mhRJUBKATADwhjmC0wgshqCMaTaGQRNeQ== X-Google-Smtp-Source: ABdhPJxvOzCM8W4klk/CbODi03E1NwZPlh5xdjiU0IEleM9nT680cmqdlvNersGdQio2+Q6KzzAk/RAzLiAdKZoccwE= X-Received: by 2002:a05:6122:1306:: with SMTP id e6mr9429827vkp.13.1639058843381; Thu, 09 Dec 2021 06:07:23 -0800 (PST) MIME-Version: 1.0 References: <20211204215820.17378-1-semen.protsenko@linaro.org> <20211204215820.17378-6-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Thu, 9 Dec 2021 16:07:11 +0200 Message-ID: Subject: Re: [PATCH v2 RESEND 5/8] i2c: exynos5: Add bus clock support To: Wolfram Sang , Sam Protsenko , Krzysztof Kozlowski , Rob Herring , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , Arnd Bergmann , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Dec 2021 at 11:11, Wolfram Sang wrote: > > On Sat, Dec 04, 2021 at 11:58:17PM +0200, Sam Protsenko wrote: > > In new Exynos SoCs (like Exynos850) where HSI2C is implemented as a > > part of USIv2 block, there are two clocks provided to HSI2C controller: > > - PCLK: bus clock (APB), provides access to register interface > > - IPCLK: operating IP-core clock; SCL is derived from this one > > > > Both clocks have to be asserted for HSI2C to be functional in that case. > > > > Add code to obtain and enable/disable PCLK in addition to already > > handled operating clock. Make it optional though, as older Exynos SoC > > variants only have one HSI2C clock. > > > > Signed-off-by: Sam Protsenko > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: Chanho Park > > This one doesn't apply here? What tree is this based on? > Based on linux-next. Might got outdated, or maybe I had some debug patches in my branch at the time. Anyway, I've sent v3 only for this patch [1]. Can you please try to apply that one? Thanks! [1] https://lkml.org/lkml/2021/12/9/584