Message-ID: <1164349c-93a5-ebb8-94aa-dbe03957c40f@gmail.com>
Date:   Thu, 9 Dec 2021 06:50:43 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH] scsi: lpfc: Use struct_group() to initialize struct
 lpfc_cgn_info
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>,
        James Smart <james.smart@broadcom.com>
Cc:     Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20211208195957.1603092-1-keescook@chromium.org>
From:   James Smart <jsmart2021@gmail.com>
In-Reply-To: <20211208195957.1603092-1-keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/8/2021 11:59 AM, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
> 
> Add struct_group() to mark "stat" region of struct lpfc_cgn_info that
> should be initialized to zero, and refactor the "data" region memset()
> to wipe everything up to the cgn_stats region.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---


looks fine.

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james