Message-ID: <5e468446-264d-ed8c-33f8-13f717bc6f9d@oracle.com>
Date:   Thu, 9 Dec 2021 09:40:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [RFC v2 4/6] crash hp: generic crash hotplug support
 infrastructure
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20211207195204.1582-1-eric.devolder@oracle.com>
 <20211207195204.1582-5-eric.devolder@oracle.com>
 <9230f9cc-1001-e3ce-aa74-10b766c8cdb0@redhat.com>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <9230f9cc-1001-e3ce-aa74-10b766c8cdb0@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHNmT0RqU0lBYmxBUHg0MW5qVm5RNG1nVGxmUlpSQVlBOGpNeGt0UjI5Ui9z?=
 =?utf-8?B?eEU2eS8zTnlnYUdmc2dxUEpjTjU0UDQvYkJGN3JYMW1LUE5mem9yQ1ZjN1Zq?=
 =?utf-8?B?aWc5cTQ5SHJhZUwzYUhzLzVIY24xT0RZQy9FZng0cmUyMGhLa0kxMjVjWWgr?=
 =?utf-8?B?L1BQc3BPckhnZmQ2WlBoQVBzNkp2YzVxcmhRMm14OVY5Tkk2UzVML3J3aE5y?=
 =?utf-8?B?eU5rQjBzS0RCbmxmV1E1U2ZvUnhPQTNZV09ub2UxVmNkUGdqYVd0TmdnUlpR?=
 =?utf-8?B?dXpWbVBDR2tMaFl6OWt5Z0ZOcnFrV2NsWmVCNnovbklsdEJoVVQ0WC9jeWx3?=
 =?utf-8?B?M0RDN1JTd0tWWmlmaFdhN0l0UkMrRTVpQWxmQm9xYlZWZTZabVY5OEhXdGFW?=
 =?utf-8?B?SjlzU1FDdmV1K1RuNXY1bkJOV1VzWlJsQTlKVVAxOFE5UmhVL0NNNDhVUjly?=
 =?utf-8?B?L1lDaXVoVUpPNk9zc3g1ZnFVRmhlSE1sRnFDOGN6ZlgzY1l0VmdkL3R4SEhw?=
 =?utf-8?B?Z3VGYzk5MTdnaGYzSWxvOFduYTFIUkxDY0N4bE42QzROQUNqTGNkWjh1cXl5?=
 =?utf-8?B?M0NjdkR3NlhpRUpaK2F0TUt3blBrcGFkYWw5SHNXbHM3bWYyZVBMZDh0MmFl?=
 =?utf-8?B?clUxWksrcHBUMnQwdXl1Z291elYwRkhSM0t4aUFHNDlUclRHMVB4THQwSnhq?=
 =?utf-8?B?b1hHRkc4d1VaL1cvcHE3RzJvK3ptRE5LaWJpakF3NW1YZW1ocm84dFdmVlY1?=
 =?utf-8?B?NVhGVXFNamM4b0lkZWhUNjRjQm45TEMzSkswSUdJNUZtYVVLdGwva0hZT2R3?=
 =?utf-8?B?R3VzZ0NtZ29BdWZCNWxGS2t2RU5ZY2dySlJJNzJvVmVKRlhLWDFkSTZXaGcr?=
 =?utf-8?B?NjIraUJDdE5SSlJDUEM4UnVDRTd5Yk8zbFA0clZNUiszS0xHSzFaUUFwWk1Y?=
 =?utf-8?B?REd5YWcxVHRVZTU3NzlON0IwekEraUFXVGxNM2NHK1NKRmkwY2pNWEZoUkpG?=
 =?utf-8?B?TEV4Ri9oRGNLM2YySUNDc2RQd1hkclRqL295dzIvTDdqOGhCWXFIeGJrT0t3?=
 =?utf-8?B?OVZ3MVNvL0ZVVHFZZDZsYXpvUjdab25PRHIzOXlQS1JaVElIMEwzRG1NUUo5?=
 =?utf-8?B?TUZFdGFPMHBJK0I0UHFtSm1iWTN6SDJiYXpUUlhjZ0NRNnQvOVAzY05tcyth?=
 =?utf-8?B?NVpobFkycS9FOUVaeEYvRnhuMmNxRW93bFJMRHc4QmZZaTlnN1ZLYUFuamt4?=
 =?utf-8?B?V2NZVEdZcU9oQzRQK2loYzFMa0gwM2IreHdGTHp5TDJQcG1hb3N4dDdjM0dL?=
 =?utf-8?B?QnV3UmdRQ1lEMnQ0dnlXeHFnYTZQTnhidjNSN2VTdGdNdjlHQnlWVDhBK3ZL?=
 =?utf-8?B?aGtvUHZpKzVLMWliVnMybGEzZVdXQVBaYTh2M0hqYjJDT2M1bE94blJ3VFFV?=
 =?utf-8?B?VjZlVjJ0a3FNQkowSDdvb3Y3Yk9ocWlWL05FamxFWWFuTG5PV2NmT2tzaWY2?=
 =?utf-8?B?ei9oV3RtWmxFU1ZPTjVRQkVScFFsM1ZKK0NydDZONS9VT3BTWWRub0VsU2hm?=
 =?utf-8?B?SVBacmx3UkI3bFF1U3FmTUN2STRtaklhelJTWWFpR2s3bHljRkx3RW9XZlVv?=
 =?utf-8?B?ZzJUZi9oZUIycjhaSGovNkFva0VRMkE2N2FLZ1hZM1dkTHNrWUFNVjllb2tp?=
 =?utf-8?B?WlpMSGppUUlCSmhBUU9rc1poVHlqSTAwcHl1MHdyN3laVmpESm1BYXcwUkZt?=
 =?utf-8?B?cktEb1V3alJxSENUYzlqbVg0QW8rWWNyOGJzbUZNTlhUWWdpWVlnUlBsRm94?=
 =?utf-8?B?ZDJFTGJON0JNa0ZRQUI4c1BxaUIxd0hiYzZ4Skx6cG9Fb1BlRjgwNUFaaVFE?=
 =?utf-8?B?N2xjUTRHQnZDaDVoWm9nSTFjOWtKOXRtSXJwNE14MkxVc1dVWDNRL01jQkxj?=
 =?utf-8?B?UjVONktDRkxEL3JLMEdMQWVxRmhVdVl6TkRWeHZuaDl1eTNvbkVGVmp5TGpa?=
 =?utf-8?B?VEpIeDFIM3VHbGhxMEpKZ0FBc3NnNEE3RXlRRXdUdzJoYnMxLzdILzdDTUtN?=
 =?utf-8?B?SElTWHBwakhNZFZVTStyVk1JL3d0QlRBeWoySDRxbEYzcjd0cjVMR1RNUmJJ?=
 =?utf-8?B?QXJFQUxoamRQQ3puVkM3VDEwOWN2NGk3cnlKWC9CbWE2TTVpYjVVMVE2WlB4?=
 =?utf-8?B?empHU0hmaTlVbUJuN3ZOOVRFb29WZHFMWXVEWmJTdTNKNkc5ekRtaW9tSkR5?=
 =?utf-8?B?dkVJNlpTZ3JlOEpIWWZQa0RmN012dW1meUg2ZEkyMllCUjBwSTViekZIMVUw?=
 =?utf-8?Q?Ns4ZH0wtnHakcVdikd?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b83c430-062a-4555-41f3-08d9bb2a3736
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:40:24.1614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V9MjQEJqYn61Vw8MR3HaHZva9zmXFmLFw9HMQ8KMH9zygO9kdv9HO0qcA9QF2VXAaywbZsD/wVYcp6ZDme9m9ZVf7HiTYcEYP+sHf05HBEo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1967
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10192 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=932 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112090084
X-Proofpoint-ORIG-GUID: TkvAmEKhe_OQNz1y-0EcKlqP3oRLWiVO
X-Proofpoint-GUID: TkvAmEKhe_OQNz1y-0EcKlqP3oRLWiVO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/21 07:38, David Hildenbrand wrote:
>> +#if defined(CONFIG_MEMORY_HOTPLUG)
>> +static int crash_memhp_notifier(struct notifier_block *nb,
>> +	unsigned long val, void *v)
>> +{
>> +	struct memory_notify *mhp = v;
>> +	unsigned long start, end;
>> +
>> +	start = mhp->start_pfn << PAGE_SHIFT;
>> +	end = ((mhp->start_pfn + mhp->nr_pages) << PAGE_SHIFT) - 1;
>> +
>> +	switch (val) {
>> +	case MEM_GOING_ONLINE:
>> +		crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY,
>> +			start, end-start);
>> +		break;
>> +
>> +	case MEM_OFFLINE:
>> +	case MEM_CANCEL_ONLINE:
>> +		crash_hotplug_handler(KEXEC_CRASH_HP_REMOVE_MEMORY,
>> +			start, end-start);
> 
> Any reason you don't handle this after the effects completely, meaning
> MEM_ONLINE and MEM_OFFLINE?
> 

No, no reason. Great catch! I've changed it to use MEM_ONLINE/OFFLINE only.
Thanks!
eric