IronPort-SDR: qjX5i9owNzNmWTfAJ52bzCNypao1pQ9pMJ9XqxA8mG9lbBT9f3w5pK2MXisbB8L4tB718dJTNo
 sd4Mqt6TWmbwW90jvraL3Y8F/HZEkj/QeG4G87ZDaiMJ+X+r8l/rg22yMR1Cg6Ys6DimjctjgN
 BmF+jjQoPkFXr5joJvL37HuYt5/NdgvTIAy0yYuSCNvVCHPuAmCoewM5CAFvjtcYj4z/HSI3lA
 iAiG+uSZfo34TaxmlwjS0HJBzge/+pzPzViCBGx6IRNqBmefAp7z+rz0VL8DgTIT9CemmLeOFm
 QVI8QDD6AnpSU/toO15/fXTA
Date:   Thu, 9 Dec 2021 16:47:09 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 5/6] net: lan966x: Add vlan support
Message-ID: <20211209154709.huq27gxgaqxgixku@soft-dev3-1.localhost>
References: <20211209094615.329379-1-horatiu.vultur@microchip.com>
 <20211209094615.329379-6-horatiu.vultur@microchip.com>
 <20211209135928.25myffd3xzcnmndl@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20211209135928.25myffd3xzcnmndl@skbuf>
Precedence: bulk

The 12/09/2021 13:59, Vladimir Oltean wrote:
> 
> On Thu, Dec 09, 2021 at 10:46:14AM +0100, Horatiu Vultur wrote:
> > +int lan966x_vlan_port_set_vid(struct lan966x_port *port, u16 vid,
> > +                           bool pvid, bool untagged)
> > +{
> > +     struct lan966x *lan966x = port->lan966x;
> > +
> > +     /* Egress vlan classification */
> > +     if (untagged && port->vid != vid) {
> > +             if (port->vid) {
> > +                     dev_err(lan966x->dev,
> > +                             "Port already has a native VLAN: %d\n",
> > +                             port->vid);
> > +                     return -EBUSY;
> 
> Are you interested in supporting the use case from 0da1a1c48911 ("net:
> mscc: ocelot: allow a config where all bridge VLANs are egress-untagged")?
> Because it would be good if the driver was structured that way from the
> get-go instead of patching it later.

Currently not, but I don't know what will happen in 1 month or 6
months.

> 
> > +             }
> > +             port->vid = vid;
> > +     }
> > +
> > +     /* Default ingress vlan classification */
> > +     if (pvid)
> > +             port->pvid = vid;
> > +
> > +     return 0;
> > +}

-- 
/Horatiu