Message-ID: <2697db33-753c-ead8-019f-5e2ef1773693@gmail.com>
Date:   Thu, 9 Dec 2021 17:03:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface
 Duo 2
To:     Katherine Perez <kaperez@linux.microsoft.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>
References: <20211208235137.2751003-1-kaperez@linux.microsoft.com>
 <20211208235137.2751003-2-kaperez@linux.microsoft.com>
From:   Konrad Dybcio <konradybcio@gmail.com>
In-Reply-To: <20211208235137.2751003-2-kaperez@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi!

On 09/12/2021 00:51, Katherine Perez wrote:
> This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350
> Chipset
>
> Signed-off-by: Katherine Perez <kaperez@linux.microsoft.com>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> ---
>
> Changes since v1:
> - Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
> - Add chassis-type
>
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   .../qcom/sm8350-microsoft-surface-duo2.dts    | 369 ++++++++++++++++++
>   2 files changed, 370 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
>
> --
> 2.31.1

[...]


> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> @@ -0,0 +1,369 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (C) 2021, Microsoft Corporation
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>

This is now included in sm8350.dtsi


[...]

> +&usb_1 {
> +	dr_mode = "peripheral";
> +};
> +

Looks like you forgot to enable usb_1, but other than these two nits:


Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>


Konrad