Message-ID: <c287f9be2a6e28da0f1342991afa94ffbcb190c4.camel@linux.microsoft.com>
Subject: Re: [PATCH] arm64: kexec: Fix missing error code 'ret' warning in
 load_other_segments()
From:   Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     dan.carpenter@oracle.com, robh@kernel.org, will@kernel.org,
        kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        bauerman@linux.ibm.com, qiuguorui1@huawei.com
Date:   Thu, 09 Dec 2021 08:32:59 -0800
In-Reply-To: <YbHHhRnpR/EtSV3f@arm.com>
References: <20211209004522.91926-1-nramas@linux.microsoft.com>
         <YbHHhRnpR/EtSV3f@arm.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Catalin,

On Thu, 2021-12-09 at 09:08 +0000, Catalin Marinas wrote:
> On Wed, Dec 08, 2021 at 04:45:22PM -0800, Lakshmi Ramasubramanian
> wrote:
> > 
> > Set return code to -ENOMEM if of_kexec_alloc_and_setup_fdt()
> > returns
> > NULL dtb.
> > 
> > 
> > @@ -149,6 +149,7 @@ int load_other_segments(struct kimage *image,
> >  					   initrd_len, cmdline, 0);
> >  	if (!dtb) {
> >  		pr_err("Preparing for new dtb failed\n");
> > +		ret = -ENOMEM;
> >  		goto out_err;
> >  	}
> 
> Above the 'if' block we have:
> 
> 	dtb = of_kexec_alloc_and_setup_fdt(image, initrd_load_addr,
> 					   initrd_len, cmdline, 0);
> 
> Looking at this function, it has several ways to fail, not just on
> allocation. However, we assume above that it's always -ENOMEM. We
> could
> do like powerpc and use -EINVAL as more likely than allocation
> failure
> or change of_kexec_alloc_and_setup_fdt() to return ERR_PTR() and we
> use
> that. The latter would be my preferred option, though it probably
> doesn't matter much. The second best would be -EINVAL.

I'll change the error code to -EINVAL and post an updated patch.

thanks,
 -lakshmi