MIME-Version: 1.0
References: <20211123124646.1995-1-thunder.leizhen@huawei.com>
 <20211123124646.1995-11-thunder.leizhen@huawei.com> <YaaitPTArUZEriob@robh.at.kernel.org>
 <0dc664f7-65ae-767c-3fe6-d1bcf50d41e1@huawei.com> <281c8196-2a5c-28cf-346a-0ae2f7182f1b@huawei.com>
In-Reply-To: <281c8196-2a5c-28cf-346a-0ae2f7182f1b@huawei.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 9 Dec 2021 11:40:32 -0600
Message-ID: <CAL_Jsq+2nt0Kr9jykq-SELk-6E4BAyFCVrRaNRC01Uz5Jqf-Jw@mail.gmail.com>
Subject: Re: [PATCH v16 10/11] of: fdt: Add memory for devices by DT property "linux,usable-memory-range"
To:     "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
        Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 8, 2021 at 7:59 PM Leizhen (ThunderTown)
<thunder.leizhen@huawei.com> wrote:
>
>
>
> On 2021/12/1 10:55, Leizhen (ThunderTown) wrote:
> >>> +   }
> >>>
> >>> -   memblock_cap_memory_range(cap_mem_addr, cap_mem_size);
> >>> +   memblock_cap_memory_range(rgn[0].base, rgn[0].size);
> >>> +   for (i =3D 1; i < MAX_USABLE_RANGES && rgn[i].size; i++)
> >> s/ &&/,/
>
> Hi Rob:
>   I want to keep "&&" unchanged, do you mind? I'm going to post an
> updated version tomorrow, hopefully the last.

Looks like that was obviously correct, so no objections.

Rob

>
> > Hi Rob:
> >
> > The comma operator may not be suitable for logical judgment. The logica=
l judgment
> > before commas (,) is ignored.
> >
> > Here's my test=EF=BC=9A
> >
> > C code=EF=BC=9A
> > int main()
> > {
> >         int i, j;
> >
> >         printf("&&:\n");
> >         for (i =3D 0, j =3D 0; i < 2 && j < 3; i++, j++)
> >                 printf("i=3D%d, j=3D%d\n", i, j);
> >
> >         printf("\ncomma:\n");
> >         for (i =3D 0, j =3D 0; i < 2, j < 3; i++, j++)    //(i < 2=EF=
=BC=89 before comma is ignored
> >                 printf("i=3D%d, j=3D%d\n", i, j);
> >
> >         return 0;
> > }
> >
> > Output=EF=BC=9A
> > &&:
> > i=3D0, j=3D0
> > i=3D1, j=3D1
> >
> > comma:
> > i=3D0, j=3D0
> > i=3D1, j=3D1
> > i=3D2, j=3D2
> >
> >