Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5f8c31b4-6223-a965-0e91-15b4ffc0335e@redhat.com>
Date:   Thu, 9 Dec 2021 18:48:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2] KVM: x86: Always set kvm_run->if_flag
Content-Language: en-US
To:     Marc Orr <marcorr@google.com>, seanjc@google.com,
        vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, thomas.lendacky@amd.com, mlevitsk@redhat.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211209155257.128747-1-marcorr@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20211209155257.128747-1-marcorr@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/9/21 16:52, Marc Orr wrote:
> The kvm_run struct's if_flag is a part of the userspace/kernel API. The
> SEV-ES patches failed to set this flag because it's no longer needed by
> QEMU (according to the comment in the source code). However, other
> hypervisors may make use of this flag. Therefore, set the flag for
> guests with encrypted registers (i.e., with guest_state_protected set).
> 
> Fixes: f1c6366e3043 ("KVM: SVM: Add required changes to support intercepts under SEV-ES")
> Signed-off-by: Marc Orr<marcorr@google.com>

Applied, though I wonder if it is really needed by those other VMMs 
(which? gVisor is the only one that comes to mind that is interested in 
userspace APIC).

It shouldn't be necessary for in-kernel APIC (where userspace can inject 
interrupts at any time), and ready_for_interrupt_injection is superior 
for userspace APIC.

Paolo