Date:   Thu, 9 Dec 2021 10:37:28 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ramji Jiyani <ramjiyani@google.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        Martijn Coenen <maco@android.com>,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH v3 0/5] aio: fix use-after-free and missing wakeups
Message-ID: <YbJM6H2wOisBY6gU@sol.localdomain>
References: <20211209010455.42744-1-ebiggers@kernel.org>
 <CAHk-=wjkXez+ugCbF3YpODQQS-g=-4poCwXaisLW4p2ZN_=hxw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wjkXez+ugCbF3YpODQQS-g=-4poCwXaisLW4p2ZN_=hxw@mail.gmail.com>
Precedence: bulk

On Thu, Dec 09, 2021 at 10:00:50AM -0800, Linus Torvalds wrote:
> On Wed, Dec 8, 2021 at 5:06 PM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > Careful review is appreciated; the aio poll code is very hard to work
> > with, and it doesn't appear to have many tests.  I've verified that it
> > passes the libaio test suite, which provides some coverage of poll.
> >
> > Note, it looks like io_uring has the same bugs as aio poll.  I haven't
> > tried to fix io_uring.
> 
> I'm hoping Jens is looking at the io_ring case, but I'm also assuming
> that I'll just get a pull request for this at some point.
> 
> It looks sane to me - my only internal cursing has been about epoll
> and aio in general, not about these patches in particular.

I was hoping that Al would review and apply these, given that he's listed as the
maintainer for this file, and he's worked on this code before.  I was also
hoping for review from Christoph, since he added IOCB_CMD_POLL originally.  But
yes, if I don't hear anything I'll just send you a pull request.  I might
include https://lore.kernel.org/r/20210913111928.98-1-xieyongji@bytedance.com
too, since it's an obviously correct aio fix which has been ignored for months.

- Eric