Subject: Re: [PATCH] perf dlfilter: Drop unused variable
To:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Salvatore Bonaccorso <carnil@debian.org>
Cc:     German Gomez <german.gomez@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211123211821.132924-1-carnil@debian.org>
 <5603b487-3e42-cfbd-200b-250c46dc0bc6@arm.com> <YbCS/xEis4QKbH6D@eldamar.lan>
 <YbJW9sHObkXC5lcz@kernel.org>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <c43649d7-aa30-f207-bae1-42809b352397@intel.com>
Date:   Thu, 9 Dec 2021 21:40:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YbJW9sHObkXC5lcz@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 09/12/2021 21:20, Arnaldo Carvalho de Melo wrote:
> Em Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
>> Hi German,
>>
>> On Wed, Dec 08, 2021 at 10:44:01AM +0000, German Gomez wrote:
>>>
>>> On 23/11/2021 21:18, Salvatore Bonaccorso wrote:
>>>> Compiling tools/perf/dlfilters/dlfilter-test-api-v0.c result in:
>>>>
>>>> 	checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
>>>> 	dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
>>>> 	  311 |         struct filter_data *d = data;
>>>> 	      |
>>>
>>> Did you get this warning when issuing "make"? From my side, it generated
>>> this gcc command so I didn't get it (make DEBUG=1):
>>>
>>>   gcc -c -Iinclude  -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
>>>
>>> Reviewed-by: German Gomez <german.gomez@arm.com>
>>
>> Only when passing -Wall (this is the case when building the kernel packages in
>> Debian with additional flags, so this is why this was spotted):
>>
>> gcc -Wall -c -Iinclude  -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
>> dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
>> dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
>>   311 |         struct filter_data *d = data;
>>       |
>>
> 
> So I'm applying this, its an obvious cleanup, but please CC the author
> next time, I'm doing it in this reply, Adrian, ok?

Yes, thank you!