From:   Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] scsi: docs: update notes about scsi_times_out
To:     Khazhismel Kumykov <khazhy@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     linux-doc@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.com>
References: <20211208225637.1054164-1-khazhy@google.com>
Message-ID: <6c50efd9-2987-067a-bc05-0a68ad908a5f@acm.org>
Date:   Thu, 9 Dec 2021 11:44:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211208225637.1054164-1-khazhy@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/8/21 2:56 PM, Khazhismel Kumykov wrote:
> + 2. scsi_abort_command() is invoked to schedule an asynchrous abort. which may
                                                                       ^^^^^^^
                                                            Should the dot perhaps be removed?
> +    issue a retry scmd->allowed + 1 times.  Asynchronous abort are not invoked
                                                             ^^^^
                                                        abort -> aborts?
> +    for commands which the SCSI_EH_ABORT_SCHEDULED flag is set (this indicates
                     ^^^^^
                 which -> for which?
> +    that the command already had been aborted once, and this is a retry which
> +    failed), when retries are exceeded, or when the EH deadline is expired. In
> +    these case Step #3 is taken.
>   
>    3. scsi_eh_scmd_add(scmd, SCSI_EH_CANCEL_CMD) is invoked for the
>       command.  See [1-4] for more information.

Thanks,

Bart.