Message-ID: <0364fb10-359e-c9c1-f90f-a01be2944dd6@fb.com>
Date:   Thu, 9 Dec 2021 14:09:13 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: ANNOUNCE: pahole v1.23 (BTF tags and alignment inference)
Content-Language: en-US
To:     Jan Engelhardt <jengelh@inai.de>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     <dwarves@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <bpf@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Domenico Andreoli <domenico.andreoli@linux.com>,
        Matthias Schwarzott <zzam@gentoo.org>,
        Douglas RAILLARD <douglas.raillard@arm.com>,
        Ilya Leoshkevich <iii@linux.ibm.com>,
        Matteo Croce <mcroce@microsoft.com>
References: <YSQSZQnnlIWAQ06v@kernel.org> <YbC5MC+h+PkDZten@kernel.org>
 <1587op7-6246-638r-5815-2ops848q5r4@vanv.qr> <YbD696GWcp+KeMyg@kernel.org>
 <57104347-7557-19rs-5845-31o122o45798@vanv.qr>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <57104347-7557-19rs-5845-31o122o45798@vanv.qr>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VUSEs1dHdTUGhIWDh4WkZtek9zc0N2b052eTB6N1drYVltcmJyMlhuZGZZ?=
 =?utf-8?B?VThZYzBSVUVIdjQwalkrRStYanNvZCtvTUI5bEljYkRCYm9qTy9pU1pnOU1W?=
 =?utf-8?B?eXczTk9vQmhZSk9BRy9LR1QyT282RHplTDFIU0Q0dHVldE9lTTUybk5qVFRK?=
 =?utf-8?B?Y1NHU2ZSSW94cDUwWlhDVTNJODhJbWpxbnRvaHpDelo3SU9rbS9kempTbzlP?=
 =?utf-8?B?ZEswc3dNZHlhaUhVRDJDTmY4VmtwNHRZU2hhdnByVFliei9zRVU0VldIaUY5?=
 =?utf-8?B?SlV3cU1kazNZUnVzR1pGNDd5S21iN0lEQUN4NFVJanFTc25FVlhjY2VrVTNV?=
 =?utf-8?B?QUtXNGxOeUNrWjl4eGNYdXNJTEw2OGJ4YzRQc255MnZDOG16WklhQVZRNXUy?=
 =?utf-8?B?ZUtsWlJpa2dFUFpyV0JuVDBOeHJQRk00VWRJSnc4NC8yTi9aRmd6MGpqMlh3?=
 =?utf-8?B?ZVYxczhYamZWWkdWYUFzcXE1STU0YlhwSk1VSTlHTGtiMzZHc1pSeityYTYz?=
 =?utf-8?B?SnVWbU10dGRTSGNYUGR5R29zQkpjRHQyTXRDNTB6dDBmQ3FQU09UWkR0ZlM1?=
 =?utf-8?B?SzFZUjNSdTdyWTllWnl6MUxLTmFuRGMza3Z1Vy9nWGt2UU92U0RXaTU4dmNZ?=
 =?utf-8?B?cEN2R1I5ckdVSWF6UzY2TnM4L0xBbFhMTFZtRnpqY3FMVElsWHZiRURaRWVL?=
 =?utf-8?B?YlRBZjJoaExwUHZ3eGJiMDR3d2hXNkFlNVdIdmhLdDlEV0wzbWhqS0Z0ZHEx?=
 =?utf-8?B?V1RPekVVWktiSGZkY0FPUG5ZWUxoS3JGa2JPL3NIWFNueS9TQjV6UkdrZzcv?=
 =?utf-8?B?cTk4OUc3YWRHOUx6ckRCOXAzSWQ2OUlpcmRrT3d4NkxOUUJYemQwRnFZcWJo?=
 =?utf-8?B?emVKZjhsdUowSVVla21PMTd6dXNha3g4b3FUYVVkUEFQaThYR3QrQ2wvUmpT?=
 =?utf-8?B?ZzkyYmdsWS94OVRrR1ZPMmRRTENoZ21Ob3JGR0JJSU5qOFBra2xxeHNTOHRY?=
 =?utf-8?B?UmNLWVU5Ym9zQnR2MVdUb2V5aEZIUkoxWUJKalhwTlpXTzhUOEFpK3RFNC9C?=
 =?utf-8?B?RXZEU1QyclZhUDJtVE1ETUhhQlBQVUJkT1lMenhyYW92Uzg2Q0c2c1FnU1Ft?=
 =?utf-8?B?a3Rnd2hBcE1Kd29kemJKbUc5RFU5YTh6eEJ6b1ZkUjBXdk01NWEySEhLY0I4?=
 =?utf-8?B?djU4VlY1QThCVGd0QlZERmFwSzhEdmxBQTZab3FFbUhKZzBycFpZdUVJOUxM?=
 =?utf-8?B?V0NXbHpWdXFiN29QdTZWVEx1bXp0NTB4cVBJSjlnL1hrbkVjSGlPKzJCU0Jz?=
 =?utf-8?B?YzZmMDE1cXBoUnI4MFl0UmVZcVZNTVkxTDhTWkoxVXhNNzFRTTE4WHlncThJ?=
 =?utf-8?B?MXdBbFJDT1JVSnVFd3dsWVU1L0lYVXY0YXo1ZEpETnJBaW8zcUNMbFV4aHI2?=
 =?utf-8?B?VDlsVHJOaFVGU0k3OWRyemN3ekQ1azYzcXBCWWdqVnRqNnRmSGZRNGZOQXAx?=
 =?utf-8?B?cElxaVp6Z0xLMUFvVFRmOEYwNktqTHk0VFQzd0FoR1ViTU5NNmtiUUJENEc5?=
 =?utf-8?B?cVlXYmxkZU1xektpd3g4RS9HV0RXVHg1QURLdG40a1dsdkNsaUlUdTkwNEp3?=
 =?utf-8?B?NUduK3R0endYS3NUWnNFeTR5b25zZW4zUk90UG9aWHZQTzZZNGoxR0FtL1ph?=
 =?utf-8?B?cnBnQnBiOUNiOEo2ejdDQno2YXV3cENBa3dtWHU4cHZoUmhxSVBQYk52bWpE?=
 =?utf-8?B?VUhFSGJITGZENERRMlJaUXFZRFdEclk2dHZBMWVGM2huTTFFQ2dKWXU5Rzhy?=
 =?utf-8?B?a3RPU3l0anVYNXJFdXZRaFBFbENHL1F4NjJJak5JZ3lwVUpYYjFvR0dsVjRO?=
 =?utf-8?B?Mm1wTTdGV3E4d3NHaW53cmtGWk12L2dQWjcyMDlNaXdYYmZmeUkwa294R1BP?=
 =?utf-8?B?R3REYTdFNkRtajd5aDZ3T3YrTGd6cVAwMmJ4dFBBcnNkbkpFcXdnL0tBaG1F?=
 =?utf-8?B?U1JJOXZQZ0F6SWUyMUpPbHNOT0JuZlp3M2U1WjMxVDhkZU9tWFFtMWwyUDZX?=
 =?utf-8?B?ZlpBSzE0SEpTTlF6dnRlbWg1MVU4ZERsa1VxVTBsdy9DMjdJN1FPckZjeXB6?=
 =?utf-8?Q?Nh6UlkfA2sJrk2Vi7YVfKbaYS?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 588ed4cf-f8ec-4959-ca2c-08d9bb608aa8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 22:09:16.8770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HXxgnBvXxHbp9atzwR0pfhg+zVMUf5adwPNBRQUuI0I01wvAoUDolqdBuq8mjkhJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2414
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: 98YcxyYpvAzYAOUcZEJytgsUcDLL1mVg
X-Proofpoint-GUID: 98YcxyYpvAzYAOUcZEJytgsUcDLL1mVg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-09_09,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 mlxscore=0
 suspectscore=0 impostorscore=0 malwarescore=0 priorityscore=1501
 bulkscore=0 phishscore=0 clxscore=1011 adultscore=0 lowpriorityscore=0
 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112090114
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/21 11:11 AM, Jan Engelhardt wrote:
> 
> On Wednesday 2021-12-08 19:35, Arnaldo Carvalho de Melo wrote:
> 
>> Em Wed, Dec 08, 2021 at 03:26:31PM +0100, Jan Engelhardt escreveu:
>>>
>>> On Wednesday 2021-12-08 14:54, Arnaldo Carvalho de Melo wrote:
>>>>
>>>> 	The v1.23 release of pahole and its friends is out, this time
>>>> the main new features are the ability to encode BTF tags, to carry
>>>
>>> [    7s] /home/abuild/rpmbuild/BUILD/dwarves-1.23/btf_encoder.c:145:10: error: 'BTF_KIND_DECL_TAG' undeclared here (not in a function); did you mean 'BTF_KIND_FLOAT'?
>>>
>>> libbpf-0.5.0 is present, since CMakeLists.txt checked for >= 0.4.0.
>>
>> My fault, knowing the flux that libbpf is in getting to 1.0 I should
>> have retested with the perf tools container based tests.
>>
>> Can you think about some fix for that? Lemme see if BTF_KIND_DECL_TAG is
>> a define or an enum...
> 
> Just bumping this line
> 
>                  pkg_check_modules(LIBBPF REQUIRED libbpf>=0.4.0)
> 
> to the right version would absolutely be sufficient for us. Of course, that
> requires that the libbpf project itself at least manages to make tags
> regularly.

Change above version 0.4.0 to 0.6.0 should work as libbpf 0.6.0 contains
all the changes related to BTF_KIND_{TYPE,DECL}_TAGs.