Sender: Tejun Heo <htejun@gmail.com>
Date:   Thu, 9 Dec 2021 12:16:31 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Lai Jiangshan <jiangshanlai@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Lai Jiangshan <laijs@linux.alibaba.com>
Subject: Re: [PATCH 3/7] workqueue: Remove outdated comment about exceptional
 workers in unbind_workers()
Message-ID: <YbKAP8LwwKlcQQpV@slm.duckdns.org>
References: <20211207073543.61092-1-jiangshanlai@gmail.com>
 <20211207073543.61092-4-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211207073543.61092-4-jiangshanlai@gmail.com>
Precedence: bulk

On Tue, Dec 07, 2021 at 03:35:39PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <laijs@linux.alibaba.com>
> 
> Long time before, workers are not ALL bound after CPU_ONLINE, they can
> still be running in other CPUs before self rebinding.
> 
> But the commit a9ab775bcadf ("workqueue: directly restore CPU affinity
> of workers from CPU_ONLINE") makes rebind_workers() bind them all.
> 
> So all workers are on the CPU before the CPU is down.
> 
> And the comment in unbind_workers() refers to the workers "which are
> still executing works from before the last CPU down" is outdated.
> Just removed it.
> 
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>

Applied 1-3 to wq/for-5.17.

Thanks.

-- 
tejun