IronPort-SDR: 6kR5lZ9LgxX6R907fMgA4T2femzK+m8S4JCeZsITh7p2agLdaePXD/yDxli3amYyMi/peNOC+L
 A22lvAZUPDf0qUEKC3CtTJUrPVZ9lxSVNqKVJf3M5GLU4B/+XHe8tfItq6n4m6DOdUw7dTUNxD
 fcy5bl+bDZAvuGb/Fq5YqVbxT4jUgbLszdMQPgTMU5GS/Gm4p/O5hVJTSRFe++DH2zKYoyo+Y8
 3yNjz+JX2ev4JqfQ+ajmYFzhBSux05becp9wS0X/vwzlkc2xoiJtkzoSvU6cET4sAZL4AZVj31
 u9nhSaZrhAmDCKqanpipfPqa
IronPort-SDR: qKGAZt8D5VknrWHxDKA9d2pPKXgU6+qbtJgJG5o/4AdrF3rAsgB3ghE21ZPJYUseBjcahamiqJ
 MvY2qyFOaLw5VN5vnnZr/BLAXF+xhd6v6Ciw4cmKDbrOKg2tjPWuVmRCx3M4OqPPTuBoFzDlif
 4JIF+O+6iENWIdVknbwaRHiocZPkmSEIsSExmIiA3TtMoLgZ8AHrPMcAEtA1+IgZXBMy7t81+m
 ShdiqMBY4LeDwN3mURCqD8oqmrVxMIkhEd2WPuC4Znzvjfxik6yMHkHg2WgXnt410UqINtbpjD
 SjY=
WDCIronportException: Internal
Message-ID: <666af6d2-ac0b-9b47-a396-a5028772cf0a@opensource.wdc.com>
Date:   Fri, 10 Dec 2021 07:26:52 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t
Content-Language: en-US
To:     Ajish.Koshy@microchip.com, john.garry@huawei.com
Cc:     jinpu.wang@cloud.ionos.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, Viswas.G@microchip.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Niklas.Cassel@wdc.com, Vasanthalakshmi.Tharmarajan@microchip.com
References: <1637940933-107862-1-git-send-email-john.garry@huawei.com>
 <PH0PR11MB51123148E4932FE1C64F8052EC669@PH0PR11MB5112.namprd11.prod.outlook.com>
 <a60318ef-dc19-a146-5ac3-16eae38b8c37@huawei.com>
 <Ya4PAu4Xj8UGHEV7@x1-carbon>
 <PH0PR11MB5112E2E7D00D95F32C86677AEC6E9@PH0PR11MB5112.namprd11.prod.outlook.com>
 <6ee6fe1b-e811-cada-0c18-78149c313358@huawei.com>
 <PH0PR11MB51120361EB6F6931CCE023D6EC709@PH0PR11MB5112.namprd11.prod.outlook.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <PH0PR11MB51120361EB6F6931CCE023D6EC709@PH0PR11MB5112.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/12/09 21:04, Ajish.Koshy@microchip.com wrote:
> Hi John,
> 
> Was testing the patch on arm server. Didn't see crash there but observing
> timeouts and error handling getting triggered for drives. But the same code
> works fine on x86.
> 
> At your end do you still face similar situation on arm server ?
> 
> Thanks, Ajish

Please do not top post. It makes it hard to follow the conversation.

Are the drives you are using SATA or SAS ?
Could you post the output of dmesg related to the errors you are seeing ?

> 
> -----Original Message----- From: John Garry <john.garry@huawei.com> Sent:
> Tuesday, December 7, 2021 07:24 PM To: Ajish Koshy - I30923
> <Ajish.Koshy@microchip.com> Cc: jinpu.wang@cloud.ionos.com;
> jejb@linux.ibm.com; martin.petersen@oracle.com; Viswas G - I30667
> <Viswas.G@microchip.com>; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; damien.lemoal@opensource.wdc.com;
> Niklas.Cassel@wdc.com; Vasanthalakshmi Tharmarajan - I30664
> <Vasanthalakshmi.Tharmarajan@microchip.com> Subject: Re: [PATCH] scsi:
> pm8001: Fix phys_to_virt() usage on dma_addr_t
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On 07/12/2021 10:36, Ajish.Koshy@microchip.com wrote:
>> Well I could see this kernel panic [  126.843958] RIP:
>> 0010:pm80xx_chip_smp_req+0x1d6/0x2e0 [pm80xx] with respect to existing
>> driver on my current system x86 64bit after enabling the following 2 kernel
>> boot arguments: -intel_iommu=on -iommu.passthrough=0
>> 
> OK, so it seems that it was the kernel which was just not enabling the IOMMU
> previously, which would be consistent with what Niklas mentioned.
> 
> Anyway, please supply reviewed-by and/or tested-by tags so that the SCSI
> maintainers can pick it up.
> 
> I suppose that we should also have:
> 
> Fixes: f5860992db55 ("[SCSI] pm80xx: Added SPCv/ve specific hardware
> functionalities and relevant changes in common files")
> 
> Thanks for testing, John


-- 
Damien Le Moal
Western Digital Research