IronPort-SDR: C5eJOhXiBlFb3CvhkJhu0qCNjkl/6hVnzz7BeWsrguNMCAo4RasHY4HR//SBB5Lj5oXK4qSd85
 HW7ZKLAWafsC47047fiTuLfqSXC3OvLMZ7FB+E4lpa3a7li2bzaefBxWHdeaCb+Q/ykAvCjAmJ
 KJ40MSHqIevKTy6nLYFlz2lCeCfO9QlVQUeYNGYk5nJDoPspLRXeAdACBFMMcHjBIaPdbQiixj
 CM0ApSRzrgiGB4vpbpe/XUt298ucC4RCzw/U0Do02b5ERNF0fKSG/koVOoG+aIkzsX0872D5uc
 6jJ+LcusvFpWmFCZSWeScvSE
IronPort-SDR: 2V+wyiVeGqndri6uoHJkm4i4uT55tSo/6ZTub25Ch4v22o95ToebIwQDeAtfi2qL4NDgeKkgJt
 GsSLy9NQL5S7jFC1N4QWytlPBfoqzjKnpcOUk69OEHGI6+mnDd8bD2IL7YeY6epk2bmphAr12F
 tH0Nf9C7rzLj9wElkXbhO8ln3joJZlCCk8DnbumOtF0k5yK8lpQUlFT3E9L6eG/FE4ec0rYUtl
 s2P36ZRN6Ix3to8LAQDz3YPjSoUWljnGsXNzULBDcgUd7TKBQbU83cmEMCT/5p5V5p82grNIyo
 WvM=
WDCIronportException: Internal
Message-ID: <d91cf14d-c7d8-1c61-9071-102f38e8c924@opensource.wdc.com>
Date:   Fri, 10 Dec 2021 07:49:38 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when
 IRQ can't be retrieved
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>
References: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/12/09 23:59, Andy Shevchenko wrote:
> platform_get_irq() will print a message when it fails.
> No need to repeat this.
> 
> While at it, drop redundant check for 0 as platform_get_irq() spills
> out a big WARN() in such case.

The reason you should be able to remove the "if (!irq)" test is that
platform_get_irq() never returns 0. At least, that is what the function kdoc
says. But looking at platform_get_irq_optional(), which is called by
platform_get_irq(), the out label is:

	WARN(ret == 0, "0 is an invalid IRQ number\n");
	return ret;

So 0 will be returned as-is. That is rather weird. That should be fixed to
return -ENXIO:

	if (WARN(ret == 0, "0 is an invalid IRQ number\n"))
		return -ENXIO;
	return ret;

Otherwise, I do not think that removing the "if (!irq)" hunk is safe. no ?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/ata/libahci_platform.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 0910441321f7..1af642c84e7b 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -579,13 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
>  	int i, irq, n_ports, rc;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		if (irq != -EPROBE_DEFER)
> -			dev_err(dev, "no irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> -	if (!irq)
> -		return -EINVAL;
>  
>  	hpriv->irq = irq;
>  


-- 
Damien Le Moal
Western Digital Research