IronPort-SDR: 6iiSNtkcZpnkH7LCXzMCcfvCqP7iUDZP/WghVKy/iw/wjv41yuSFYNcuRIF9CslkTjxiShI9vv
 bPpdyUF+l6sCVTk6PiGOuodE+1vwdn+LLYXS7lA3LIlFeBM1buUVPzNCBf1C8CYWoi7/Yt0Xdt
 iWTqAGa/fL+GVA/1O3N400PTCGubcpY3w5IknUhbHYeh2P+Fl0upNs3/00Xh3hLafosWEbOPnC
 NRrIjeLu7al2HEHW/j1d2sX8LP08JWEHs8j2V1Sjah10B4ZJf9QgTRtbaOCSHktGn87wu5xkZD
 kb/Vn6hYH2uP8uSiyTbiAjBY
IronPort-SDR: +2EZjYcJD8Rpi7Hzt+ryR6Zrp7rMKMr5V6S/bpMMXT/TvTSXZwchnpzu6B4bheVNNgHv021EFu
 CywJUzOaYOUMH+8j0pa5lqM1tt8KzygD2iAyyaYH/rE8ufSBTZ4kmAs69ajEq5S54mH4gyqxr1
 KiZIvYX1QwynkuBwHCL6ua+yll1Ud1u85Io6mtp0AjXRb8fBzwKk/cJhJqDuZwVeiYNt28Dq+Y
 2+r0ZIhOB7s7vu9S7O2jOcKPqT+M8efH6enH01olPLqNy+jYxW+/YtBIjd5XdsGE6SVoyV93oc
 fSM=
WDCIronportException: Internal
Message-ID: <cf7b4f8b-3423-0cb3-c765-c2903a5f2e4d@opensource.wdc.com>
Date:   Fri, 10 Dec 2021 07:57:48 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when
 IRQ can't be retrieved
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>
References: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com>
 <d91cf14d-c7d8-1c61-9071-102f38e8c924@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <d91cf14d-c7d8-1c61-9071-102f38e8c924@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/12/10 7:49, Damien Le Moal wrote:
> On 2021/12/09 23:59, Andy Shevchenko wrote:
>> platform_get_irq() will print a message when it fails.
>> No need to repeat this.
>>
>> While at it, drop redundant check for 0 as platform_get_irq() spills
>> out a big WARN() in such case.
> 
> The reason you should be able to remove the "if (!irq)" test is that
> platform_get_irq() never returns 0. At least, that is what the function kdoc
> says. But looking at platform_get_irq_optional(), which is called by
> platform_get_irq(), the out label is:
> 
> 	WARN(ret == 0, "0 is an invalid IRQ number\n");
> 	return ret;
> 
> So 0 will be returned as-is. That is rather weird. That should be fixed to
> return -ENXIO:
> 
> 	if (WARN(ret == 0, "0 is an invalid IRQ number\n"))
> 		return -ENXIO;
> 	return ret;
> 
> Otherwise, I do not think that removing the "if (!irq)" hunk is safe. no ?

Replying to myself :)
I replied before reading Sergei replies that points this out.

> 
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  drivers/ata/libahci_platform.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
>> index 0910441321f7..1af642c84e7b 100644
>> --- a/drivers/ata/libahci_platform.c
>> +++ b/drivers/ata/libahci_platform.c
>> @@ -579,13 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
>>  	int i, irq, n_ports, rc;
>>  
>>  	irq = platform_get_irq(pdev, 0);
>> -	if (irq < 0) {
>> -		if (irq != -EPROBE_DEFER)
>> -			dev_err(dev, "no irq\n");
>> +	if (irq < 0)
>>  		return irq;
>> -	}
>> -	if (!irq)
>> -		return -EINVAL;
>>  
>>  	hpriv->irq = irq;
>>  
> 
> 


-- 
Damien Le Moal
Western Digital Research