Subject: Re: [BUG] eth0 appers many times in /proc/interrupts after resume
From: Andrei Popa <andrei.popa@i-neo.ro>
Reply-To: andrei.popa@i-neo.ro
To: Frederik Deweerdt <deweerdt@free.fr>
Cc: linux-kernel@vger.kernel.org, nigel@suspend2.net
In-Reply-To: <20070121212209.GB8958@slug>
References: <1167520557.2566.23.camel@nigel.suspend2.net>
	 <1167571281.7175.1.camel@localhost>
	 <1167599458.2662.8.camel@nigel.suspend2.net>
	 <1167605481.12328.0.camel@localhost>
	 <1167607994.2662.39.camel@nigel.suspend2.net>
	 <1167644970.7142.6.camel@localhost>
	 <1168317278.6948.9.camel@nigel.suspend2.net>
	 <1168448689.7430.1.camel@localhost>
	 <1168463852.3205.1.camel@nigel.suspend2.net>
	 <1169407062.1932.4.camel@localhost>  <20070121212209.GB8958@slug>
Content-Type: text/plain
Organization: I-NEO
Date: Tue, 23 Jan 2007 11:12:49 +0200
Message-Id: <1169543569.10364.2.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1398
Lines: 43


It's ok, after 4 suspend/resume cycles, eth0 only appers one time.

On Sun, 2007-01-21 at 21:22 +0000, Frederik Deweerdt wrote:
> On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote:
> > It's the 10th resume and in /proc/interrupts eth0 appers 10 times.
> > 
> Hi,
> 
> The e100_resume() function should be calling netif_device_detach and
> free_irq. Could you try the following (compile tested) patch?
> 
> Regards,
> Frederik
> 
> Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
> 
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 2fe0445..0c376e4 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -2671,6 +2671,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
>  	del_timer_sync(&nic->watchdog);
>  	netif_carrier_off(nic->netdev);
>  
> +	netif_device_detach(netdev);
>  	pci_save_state(pdev);
>  
>  	if ((nic->flags & wol_magic) | e100_asf(nic)) {
> @@ -2682,6 +2683,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
>  	}
>  
>  	pci_disable_device(pdev);
> +	free_irq(pdev->irq, netdev);
>  	pci_set_power_state(pdev, PCI_D3hot);
>  
>  	return 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/