From:   Qing Wang <wangqing@vivo.com>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Paul Mackerras <paulus@samba.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] powermac: low_i2c: Add missing of_node_put for loop iteration
Date:   Fri, 10 Dec 2021 00:11:51 -0800
Message-Id: <1639123911-31736-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6dFExIfx8JtFl6uawMHJO4dHm4Utjz8E11yc9lAbCKb5iFR1VlCzk2ojmEk3?=
 =?us-ascii?Q?kPW10D2T4pXEUqBSxLcaugbFJ83cKm8aVTUNsGlwiovyAHAaS+kTKP2W37PG?=
 =?us-ascii?Q?CJQi/rKM49cJq+ylqT85rrdEoeQfTyTMy8ytijdjInblBH+OlYPc1mLwtpdo?=
 =?us-ascii?Q?bmHpj6nos73G1TylZ9WLZTzwnqqWn94/ImYyK6wsr3WRcIadfR2aZI8QswOh?=
 =?us-ascii?Q?iNuroi3JUqxC5H3/aq0Fyh6tLx6u6zG+6EUurnhovIztkkD+gGIYYKUkXIRg?=
 =?us-ascii?Q?hGTox2HhXv6bQhHaw7u6euFOeFbFv1Vy/6Yi9wq54yW0fBZs87tblxZWWobr?=
 =?us-ascii?Q?A3oV3a2QXW4lsz/vqben0ApKCJ7MoSHkXhy88oPPzhl2zTx3DRw708T2REJm?=
 =?us-ascii?Q?va0rEOj5in3To2aFhE90EiLucv1eS9Sygl6x8YQHuOXPyNfXIZnMdWxokge7?=
 =?us-ascii?Q?gA9n2OFzzSGexGPjlLK1zKXFtx+3Zmh8XD69YVR5FrGzVx2Kb+2OqK628J1H?=
 =?us-ascii?Q?koO+sret7j19gpK98p/fiAWnitvd7tnIm/xUnNRbt8pu5ZBLAQ3uaQiIjdqF?=
 =?us-ascii?Q?CHQL/hziohX6ERsSSlmg79JPCtAQnyHHifcNjafys+oL5Ui2oYeGVWPuJZMs?=
 =?us-ascii?Q?JStch/oP/Z9ZuseNlMGTdSLAfoxnE7XUYKWMrSEVgJkBgkX51TiU2YQpsSaJ?=
 =?us-ascii?Q?KJlSk78hSwfPWLC+z/FoAdxVhwRX7ZK6IbrWX5k+sPJ3frigVGokcr1LDkkv?=
 =?us-ascii?Q?rfTp5Knt5CER4vRVWu0ow1pA0FuBuYq3PZSAS+8nxjdw1uOChTsd6cWfumOn?=
 =?us-ascii?Q?LR/sZ3XxxorL7I5bSwbVvwOMs5Rhjzouk+yjIm/vTv60d6BcjhMB9blDhSIc?=
 =?us-ascii?Q?DNBEON8VsqAUSq2ziPBaqHZSc3exXKMQHAq1nK7AB+NjGDblVwQ29EvtIL68?=
 =?us-ascii?Q?WM445tXNPZuFCzABff9Uz+aBL+0Eex58k2VLW+FVwUyz6nMVQRd6ZU3kuSMy?=
 =?us-ascii?Q?XszSzQXUs7C2dkYRfANqEGOiqFRWUWR44d4dAD+NCHZAbnAayr+Rg+rjp8pn?=
 =?us-ascii?Q?KUoDsM8WLKhvVEYDunXCazS9UIUUdxjl/q7TSNfS4rxm4nFwRfVMvxPtGgya?=
 =?us-ascii?Q?5rbCm5eBEnWntOF34HFDhVLMYqdOiaV0I7tZ6K4SYWkjNJfBMq1vqXhbi/7b?=
 =?us-ascii?Q?TkOjBAuWfZQa8DGNhh5PUZyEk7tRxxow9B+tLN7vus7sDhbYgqeu1ccUf2vN?=
 =?us-ascii?Q?sTYxk7N9jWl05zF4NlmDKi8WfH2sDvw/T+3Y6D2F4HEi7qavhKMDfoAMXIuN?=
 =?us-ascii?Q?UNU88/ssTE0ljmJP6UJhDlZ41uUYfqni3iyovSjKq3uUwLiqS/2OEIoIdkTb?=
 =?us-ascii?Q?O2eoQBgxSjmAs7puA378wVYMMVktH2FkdPJI4BWQnPAKe/1XFc3lYWh8bUuj?=
 =?us-ascii?Q?BgltsLQA6n1z3JkDo2Kk4Zl5GfWGzFMtzvZkPhO+dwcyr8fufAcBm6SKbssr?=
 =?us-ascii?Q?cqaEeF/q5H7IdbYCtvIE2D6svYfJFsuDHmZvICOx1k/7E3P92oyDWDziRtGA?=
 =?us-ascii?Q?Are1FAkYmd2LYG97R3L+0jaXxIeK/39kYv5RnhndK7VMtLpddRa4HgoAnd6T?=
 =?us-ascii?Q?BUbiF/bjAOpg3Lm+AEGOkJA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55017e37-ad22-4937-e3a0-08d9bbb4c501
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 08:12:12.5677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xl+HfWgVM7T0HpkAgWEPFv4d/WPtj60z2Lp+IBWHqcuZBVz86DFAn+cIF8rAG2gJZFKbJVJxi+PHOGaZmqfcjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3033
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

arch/powerpc/platforms/powermac/low_i2c.c:916:1-23: WARNING: Function 
"for_each_child_of_node" should have of_node_put() before return.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 arch/powerpc/platforms/powermac/low_i2c.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
index f77a59b..5a8c306
--- a/arch/powerpc/platforms/powermac/low_i2c.c
+++ b/arch/powerpc/platforms/powermac/low_i2c.c
@@ -922,8 +922,10 @@ static void __init smu_i2c_probe(void)
 
 		sz = sizeof(struct pmac_i2c_bus) + sizeof(struct smu_i2c_cmd);
 		bus = kzalloc(sz, GFP_KERNEL);
-		if (bus == NULL)
+		if (bus == NULL) {
+			of_node_put(busnode);
 			return;
+		}
 
 		bus->controller = controller;
 		bus->busnode = of_node_get(busnode);
-- 
2.7.4