From:   "Chindris, Mihail" <Mihail.Chindris@analog.com>
To:     Rob Herring <robh@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "Sa, Nuno" <Nuno.Sa@analog.com>,
        "Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
        "alexandru.ardelean@analog.com" <alexandru.ardelean@analog.com>
Subject: RE: [RESEND, PATCH v6 1/2] dt-bindings: iio: dac: Add
 adi,ad3552r.yaml
Thread-Topic: [RESEND, PATCH v6 1/2] dt-bindings: iio: dac: Add
 adi,ad3552r.yaml
Thread-Index: AQHX6r9H97OwZzV1N0a8StCfthzSbawl/oqAgAVyznA=
Date:   Fri, 10 Dec 2021 09:05:15 +0000
Message-ID: <SN4PR03MB6799D9A834144D6E00187B3B99719@SN4PR03MB6799.namprd03.prod.outlook.com>
References: <20211206163529.3528-1-mihail.chindris@analog.com>
 <Ya6DhTiU23k839M0@robh.at.kernel.org>
In-Reply-To: <Ya6DhTiU23k839M0@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gs8secX5oyJ+Pgdql6ndk4bUROEU3d7Z9KotI7CXL71Vb8um1/qhqqVdzRLG?=
 =?us-ascii?Q?qKjuWXPDaxuFX/PHDVJqTL/I/jobw3WU9E9MDcGKrPzbqoyczf4HHc3/6+RK?=
 =?us-ascii?Q?25e6FYqMyssdGT1Cvp8qe9GL5DUmNGS5E3kIkbU9nfnAujX1+4g8OF0cnINe?=
 =?us-ascii?Q?UE9KfxOu4QzI+aoCcc/El5V/bBYkuDrUOeo/N3LklY0cN+UQQjYNtDAWHQlv?=
 =?us-ascii?Q?ITtKc2WCK2jGWEz0BBUmCbZSjlareaTQzTyHJMNP2AP0gCEVfg59aOh+9J+t?=
 =?us-ascii?Q?TULcTZDnJXnl9P6X6Im18A1yBvMAtfds9+LuP54NYxsG1xOXyd0YeEZrGdDP?=
 =?us-ascii?Q?qM5rEzgl+1s01YOF/mTgxh4w6YceoKz7qrhWJXaH7ARvCV138XTO8Icnl2ez?=
 =?us-ascii?Q?VuNpYAi33Wfqd33k0hmW1UMj2ULmzNyDwFQkNZbNJm3x6Z19Kuxmnun2AW3b?=
 =?us-ascii?Q?7rM9yWJ4dMAXS2Zs4nMDtqw/ibxvCvgtAaYkEI8ApHrvFEp5wkQw43Z96XLI?=
 =?us-ascii?Q?McB9ZtE8+ZWKpdv7+lfvCVs6SX928tMyPgGxiY1T+77dRulmFtjlWyAgRjpA?=
 =?us-ascii?Q?RJVmz7xC4CUH0R+IaH43h4H0QtgWtZub4dhX6cnLH9qRe6TRVyEB2nMY5N4O?=
 =?us-ascii?Q?O1v3ZInIYVxYpMLhnEGGRHuQOZVRcltYkJDSndN+lJ5vTTQ/CmoeN9Ju/lcc?=
 =?us-ascii?Q?BqICBhh3fNK2g5xLJB1iJSd19LzwdenoGvbD5AvxzNpEcZMgPnZG2VMze8pB?=
 =?us-ascii?Q?kZDM7XEot8kmU4v5Z6O2DBXpycU29SHaNzSWUVVw/2x8yxAmh8dTgVLSM7wT?=
 =?us-ascii?Q?gIb63b8AwG1EtM8pDttOuI385S3/8i3pAKjUhtHaVkxADb0neNKcid48+N9b?=
 =?us-ascii?Q?HXZpJ33VGqg/QLkuCkPbThxVblvW9G+h0RGNGZ2K7Sc0tmSLBhnkEy/LohRn?=
 =?us-ascii?Q?HsRObzfFaiJJqwLF9oX7cFfa6Gji6VRS8TuqvYfWV/mWIgZ9ir+ZYmbRKifx?=
 =?us-ascii?Q?o4Q0oUONGgd2k/XIZk9jF1JO5NbNHbLGZBLMkltHGGjNxZD9OyHY5h3PH9hc?=
 =?us-ascii?Q?8ESdCYQUJ7j0oyFJcCiWkxvG19xLyTCTjq1QHCE4hKO4UWh1SKeycwxikJ0z?=
 =?us-ascii?Q?qy+cNvgso5KxRB9S6UcIz8Ki47c2y3LTaRU8WVA5E3WifJtbBrwR/tl3RyBm?=
 =?us-ascii?Q?J+yaw69odCV7T2m40kJRfl1udkTPxQElSXH7Li3adwaCHRFj54aEPpOevMhS?=
 =?us-ascii?Q?/o13FLhveh1mbE5c3pvv7hsjPAMxQ3AOCCUKVbkLCZv5rKKekU62+M+H26fM?=
 =?us-ascii?Q?f6g0zVBaVtXcEc9DyAd2Rp8DIeP0SAPzsjl6K5rtWsP3qGdEdczgb7FHD7AK?=
 =?us-ascii?Q?IVyBXuJCb+1931tJmezGUGMSGCW3kr4S/90/fqA33QnO7p7WFRNBIPEquNKO?=
 =?us-ascii?Q?hCzk/jVvZJpNC/TeTqiH2tzfe0HZG/LUZyD4dEyfoB583l+c48OgL8KzLgce?=
 =?us-ascii?Q?xGva8bWh/7kakz/wLpEcoW42MQvfwVhdtFG+bKudIXmWffsA13OUSpFcToAJ?=
 =?us-ascii?Q?/TcZOU0L/3zZx2aGXwrQpKncA/nMSU3LnTHa04Knf3cEiUtqghSAhCsl1nx7?=
 =?us-ascii?Q?APSuTu7oO0R8z5i983XtH2aYVFssawK5phFeEdJB4WJx0qq6BTKWiKxr5zXS?=
 =?us-ascii?Q?cZ/UXYp/qPXM2SeOqTVkOK8YIXHuvS1uD9D1JzFSENZ9KtzuqQVEPCBoQzS3?=
 =?us-ascii?Q?3jpBjMwOdg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR03MB6799.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c583de64-5c27-4575-12c6-08d9bbbc2e47
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2021 09:05:15.2270
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h/sB0+xt5hXuHRdyN+rsZXTPDJKzz/fXt+UZvap6IkpqLJqeSN0kHppUoGixdOoU5EqCGRzBBkJ4XXWYhxZ6oDediPFnzf4X4Qrt68ljPnc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6641
X-Proofpoint-GUID: 6tWXapfHaJtm0ntAaDSb6HUgsUBUZqXm
X-Proofpoint-ORIG-GUID: 6tWXapfHaJtm0ntAaDSb6HUgsUBUZqXm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-10_03,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0
 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011
 priorityscore=1501 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112100049
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob

I will fix the build and update the patch.
I have a question below until then though.

Regards,
Mihail

...

> > +
> > +      custom-output-range-config:
> > +        type: object
>=20
> Why does this need to be in a child node?

For an ad3552r or ad3542r you can setup a default output range and a custom=
 one (only one of these options is possible). The custom range is configure=
d with this child and the default can be choose with the adi,output-range-m=
icrovolt property below

The adi,output-range-microvolt is described bellow for each chip. I couldn'=
t find a way to put it here.
Do you have any suggestion?

Mihail

>=20
> > +        description: Configuration of custom range when
> > +          adi,output-range-microvolt is not present.
> > +          The formulas for calculation the output voltages are
> > +            Vout_fs =3D 2.5 + [(GainN + Offset/1024) * 2.5 * Rfbx * 1.=
03]
> > +            Vout_zs =3D 2.5 - [(GainP + Offset/1024) * 2.5 * Rfbx *

...