Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner
To:     cgel.zte@gmail.com, peterz@infradead.org
Cc:     mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, chi.minghao@zte.com.cn,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zeal Robot <zealci@zte.com.cm>
References: <20211210022911.424512-1-chi.minghao@zte.com.cn>
From:   kajoljain <kjain@linux.ibm.com>
Message-ID: <708b524c-2af5-98a1-f56a-4bb4f268de7a@linux.ibm.com>
Date:   Fri, 10 Dec 2021 14:41:55 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211210022911.424512-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/10/21 7:59 AM, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> return value form directly instead of
> taking this in another redundant variable.

Can we reword the commit message stating what and
from where we are removing it. Its not too clear.
Other than that patch looks good to me.

Reviewed-By: Kajol Jain<kjain@linux.ibm.com>

Thanks,
Kajol Jain

> 
> Reported-by: Zeal Robot <zealci@zte.com.cm>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  tools/perf/util/callchain.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index 8e2777133bd9..ed30da7e14ab 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -1301,24 +1301,16 @@ int callchain_branch_counts(struct callchain_root *root,
>  
>  static int count_pri64_printf(int idx, const char *str, u64 value, char *bf, int bfsize)
>  {
> -	int printed;
> -
> -	printed = scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
> -
> -	return printed;
> +	return scnprintf(bf, bfsize, "%s%s:%" PRId64 "", (idx) ? " " : " (", str, value);
>  }
>  
>  static int count_float_printf(int idx, const char *str, float value,
>  			      char *bf, int bfsize, float threshold)
>  {
> -	int printed;
> -
>  	if (threshold != 0.0 && value < threshold)
>  		return 0;
>  
> -	printed = scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
> -
> -	return printed;
> +	return scnprintf(bf, bfsize, "%s%s:%.1f%%", (idx) ? " " : " (", str, value);
>  }
>  
>  static int branch_to_str(char *bf, int bfsize,
>