Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for
 usbhid device
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jiri Kosina <jikos@kernel.org>, benjamin.tissoires@redhat.com,
        gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
        mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
        rajatja@google.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, zhuyinbo@loongson.cn,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Rajat Jain <rajatja@google.com>,
        Chris Chiu <chris.chiu@canonical.com>,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1638956391-20149-1-git-send-email-zhuyinbo@loongson.cn>
 <YbCdTaGSKak1cdSh@kroah.com>
From:   zhuyinbo <zhuyinbo@loongson.cn>
Message-ID: <cc535d3d-6dcd-e69c-24e7-df54ce63c381@loongson.cn>
Date:   Fri, 10 Dec 2021 17:54:33 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <YbCdTaGSKak1cdSh@kroah.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2021/12/8 ????7:55, Greg Kroah-Hartman д??:
> On Wed, Dec 08, 2021 at 05:39:50PM +0800, Yinbo Zhu wrote:
>> The remote wake-up function is a regular function on usb hid device
>> and I think keeping it enabled by default will make usb application
>> more convenient. This patch is to enable remote wakeup function for
>> usb hid device.
> 
> How many devices did you test this on?
> 
> As Oliver said, this will cause problems, there's a reason no operating
> system does this :(
> 
> sorry,
> 
> greg k-h
Hi greg,

About that oliver said that I had expained, and I add this change was 
according that usb device whether support remote wakeup and if it 
support wakeup then to enabled it so I think it should be okay for all 
hid device.

BRs,
Yinbo.
>