Subject: Re: [PATCH] tools/perf: remove unneeded variable make code cleaner
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     cgel.zte@gmail.com, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, chi.minghao@zte.com.cn,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zeal Robot <zealci@zte.com.cm>
References: <20211210022911.424512-1-chi.minghao@zte.com.cn>
 <708b524c-2af5-98a1-f56a-4bb4f268de7a@linux.ibm.com>
 <20211210104203.GT16608@worktop.programming.kicks-ass.net>
From:   kajoljain <kjain@linux.ibm.com>
Message-ID: <500a4cce-1e71-fd8a-8fa3-39eb09964e97@linux.ibm.com>
Date:   Fri, 10 Dec 2021 18:14:46 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211210104203.GT16608@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/10/21 4:12 PM, Peter Zijlstra wrote:
> On Fri, Dec 10, 2021 at 02:41:55PM +0530, kajoljain wrote:
>>
>>
>> On 12/10/21 7:59 AM, cgel.zte@gmail.com wrote:
>>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>>
>>> return value form directly instead of
>>> taking this in another redundant variable.
>>
>> Can we reword the commit message stating what and
>> from where we are removing it. Its not too clear.
>> Other than that patch looks good to me.
>>
>> Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
> 
> Never reply or accept email from cgel.zte@gmail.com, there's multiple
> people using it to send email, this cannot be right.
> 

Sure peter, Thanks for pointing it. Will take care next time.

Thanks,
Kajol Jain