Subject: Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support
To:     Jason Gunthorpe <jgg@ziepe.ca>, Shunsuke Mie <mie@igel.co.jp>
Cc:     Zhu Yanjun <zyjzyj2000@gmail.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Doug Ledford <dledford@redhat.com>,
        Jianxin Xiong <jianxin.xiong@intel.com>,
        Leon Romanovsky <leon@kernel.org>,
        Maor Gottlieb <maorg@nvidia.com>,
        Sean Hefty <sean.hefty@intel.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        linux-media@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Damian Hobson-Garcia <dhobsong@igel.co.jp>,
        Takanari Hayama <taki@igel.co.jp>,
        Tomohito Esaki <etom@igel.co.jp>
References: <20211122110817.33319-1-mie@igel.co.jp>
 <CANXvt5oB8_2sDGccSiTMqeLYGi3Vuo-6NnHJ9PGgZZMv=fnUVw@mail.gmail.com>
 <20211207171447.GA6467@ziepe.ca>
 <CANXvt5rCayOcengPr7Z_aFmJaXwWj9VcWZbaHnuHj6=2CkPndA@mail.gmail.com>
 <20211210124204.GG6467@ziepe.ca>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <880e25ad-4fe9-eacd-a971-993eaea37fc4@amd.com>
Date:   Fri, 10 Dec 2021 13:47:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211210124204.GG6467@ziepe.ca>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGlCYzhNSUV0ejBHQWNtQUw3c2t6RXNGQ1pvb3hrM1BPekJ1cUwxQk42dTBl?=
 =?utf-8?B?NzVKelQweGhsai8xMWVvUUhMR1hCREZ2VjdIbVdLQjhHVkgxZlVsSTd6bjlM?=
 =?utf-8?B?WXNTaUltVG9tdklVTXpSeUV6UUpRTTh3QjdXNDVMbHAxTmJKeWh3WFo1V1d3?=
 =?utf-8?B?WTFSQmlhRGlDNTROS09PTjU3LzRpVG1BRlNPYklOd1o1YlVVUTh5TnpIZU1a?=
 =?utf-8?B?OSttZmtmaTdVOVVtRlhKRUU1N3NsUC8rc2J1SklkZnFvUzFsV28wZjFMOGp0?=
 =?utf-8?B?a0xBWGNKV0ttVkIyUWdhSGE4cHhMSUZJV3hCalB6ZTZCdk5nYW54Y1NDMEpR?=
 =?utf-8?B?ZDFyb21XT2d3UncxNm05UDVCNUIwOFNCQWJjVXFvQ05PNy9ZUUx4UzVmaDNP?=
 =?utf-8?B?elR3dWd6c3RFajJyaGxhZzJNeExsdEFNMEpFN3lDaFcweXRyUUVyenFhenR0?=
 =?utf-8?B?YitLRGRDbGxkTHNFcWprUVpITjJCQzdnSEduSkRtUHRHaXRBVW5BaDZyYTkr?=
 =?utf-8?B?MmNrU1phRjRYVVVTMFN1L2dYSkxuNm1heXk1cjhQcDFMWkFKTjQ0Q2h1SXhs?=
 =?utf-8?B?VU5mSW0wTGZ6Z0IyNzB0YW1rZG91VHJ4YnYwVFcwaE1Va2hjRStwUXdEb2Jr?=
 =?utf-8?B?WnRYdUZKbHI3OWFkeUFPa3YrOGgzdms4Y255Wk1KNnNFZjZFY0hMN0Z3R0ZC?=
 =?utf-8?B?V1Z2MjdpQnlmTW51UXVBNVRLczFJejB0NFFkMU1hM2llbXF4M2xqUzRmQlFG?=
 =?utf-8?B?YkYwNVRqY0RuNm9FbTdadG0yWTRvREQvM0VWQnV4WE0rZGluanV5cjdFVkcz?=
 =?utf-8?B?Ry9GNjJxYW8xZXBJckRNMUl3Mlpua2Y2aFA5Z0tGallkSzZVQkdlYzlGejFp?=
 =?utf-8?B?UDNXNmpGdDZZWk5OK1hDQ2RuQmFNbnR6cHBhNDFmbkJwRllxcUtxSGhkdmJq?=
 =?utf-8?B?MHlnV2N2dWJIZ2VvaENWN3lSQjJ2R1ZLdm1XM2NKeUZhVGNRaHN3a21hYS9R?=
 =?utf-8?B?ZUZFT21ORFhwK1FYTFQzbjJhS0gzKzUzVzdoMHROMjIyRE1ZREt1SkNWY2RV?=
 =?utf-8?B?bkd6RmhqM2pEenozV29nbGhHWWhqbDJGSm1MM3NvYWtyVG1TK3kwTXVUL0Qr?=
 =?utf-8?B?SS9OYlB2OWJwcVVtVUoybzRBZ2dEbUFoSnd5NmZMb1lmWmNiYXFiTGdJbnM0?=
 =?utf-8?B?cEVIeUdXZWt2U2Zoc1JITUtuUEg3Z283THZmZ0kvN0plTUwyaWY5cXBCanBU?=
 =?utf-8?B?Y2JZbVRnbjJ1bUlrTkFabjI1SUpiZGE3THRYb21uSTd6emtMOThjRHdpdnA3?=
 =?utf-8?B?Y1RCOWY2U0E4U1c0dWs4TnNLQTc2TEVzZHA1TWJiY2FJYUV4ZGM5YmVwWnRw?=
 =?utf-8?B?czg1NnVPMUVIWXR5c1VJNStGRTZKZVBMNlNFUkRJNG4yYm9SKzkvdXNDcVpl?=
 =?utf-8?B?WnlvL0tVYkRBa1R5RXZTWlFWWVdHUTkvcWlrY0Z5WUFyNExRRUVTSEFIb244?=
 =?utf-8?B?dVMxSGhLbU9DNDFSL1dNcytCU1IxRFVma240SmNQMmpCVmVTejJvREZ0UlFX?=
 =?utf-8?B?a0djRHlXbktPN0JmZ011WHNXUDNmZTE3b1dYTTJGOE5SZjhFOENWZHBXN1Fz?=
 =?utf-8?B?V0V5MTJNOERzc3lvUk5TZ290L294akVRU3dPQnZvTElyWURyMlNDTkF5cGxN?=
 =?utf-8?B?SmJwa005WDVzV1cybW5OVUc0UStHeFhoMGxFSmU4UnFDUDIwRkNpWGlDczFC?=
 =?utf-8?B?bmpEZHRQdnVQMmw2a1lHeFAzNW9ZcUJ1bkEwaklwc2sxNk41Z0xSelh2NFBS?=
 =?utf-8?B?ZGtrOG1oUnNnbmpBbktrTnNlVHBlK2twSDVVV2pRUWtGTjFlRlM0cVVlcVRF?=
 =?utf-8?B?YTcwWjhIWWYvRWdkWHdoeGlSOG5FaVhITmFDWStuRTZYTUJxcys5TUZQTml6?=
 =?utf-8?B?bUk0bDlPQXdmWG15WUc5ZlR1cUY5alVUWUNYRys1bUs1L0JwcndOTjZ5TzND?=
 =?utf-8?B?UVZzei9rWG5RSHU0YzNXdjIzZmJkZi9JNmhBcWloaHpOMXdpZEE2aTFDaGRs?=
 =?utf-8?B?SnNiRVVobkZDbFJOb0FBM2llL29Ha3kzV3Z4QnR0TVNCVlI5VGoreE91ek9i?=
 =?utf-8?Q?p33U=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2cad2fd-5bd3-4e75-1d88-08d9bbdb459c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 12:47:49.2975
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YWQuidDOvIGPLeBPoh9GgBm51gaFoVk2lXUiso8e/QFU49T3CqzosjeE5tjRK4fd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1776
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 10.12.21 um 13:42 schrieb Jason Gunthorpe:
> On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote:
>> Hi Jason,
>> Thank you for replying.
>>
>> 2021年12月8日(水) 2:14 Jason Gunthorpe <jgg@ziepe.ca>:
>>> On Fri, Dec 03, 2021 at 12:51:44PM +0900, Shunsuke Mie wrote:
>>>> Hi maintainers,
>>>>
>>>> Could you please review this patch series?
>>> Why is it RFC?
>>>
>>> I'm confused why this is useful?
>>>
>>> This can't do copy from MMIO memory, so it shouldn't be compatible
>>> with things like Gaudi - does something prevent this?
>> I think if an export of the dma-buf supports vmap, CPU is able to access the
>> mmio memory.
>>
>> Is it wrong? If this is wrong, there is no advantages this changes..
> I don't know what the dmabuf folks did, but yes, it is wrong.
>
> IOMEM must be touched using only special accessors, some platforms
> crash if you don't do this. Even x86 will crash if you touch it with
> something like an XMM optimized memcpy.
>
> Christian? If the vmap succeeds what rules must the caller use to
> access the memory?

See dma-buf-map.h and especially struct dma_buf_map.

MMIO memory is perfectly supported here and actually the most common case.

Christian.

>
> Jason