Date:   Fri, 10 Dec 2021 06:56:44 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     cgel.zte@gmail.com, mathew.j.martineau@linux.intel.com,
        davem@davemloft.net, shuah@kernel.org, netdev@vger.kernel.org,
        mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Ye Guojin <ye.guojin@zte.com.cn>,
        ZealRobot <zealci@zte.com.cn>
Subject: Re: [PATCH] selftests: mptcp: remove duplicate include in
 mptcp_inq.c
Message-ID: <20211210065644.192f5159@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211210065437.27c8fe23@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20211210071424.425773-1-ye.guojin@zte.com.cn>
        <ab84ca1f-0f43-d50c-c272-81f64ee31ce8@tessares.net>
        <20211210065437.27c8fe23@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 10 Dec 2021 06:54:37 -0800 Jakub Kicinski wrote:
> On Fri, 10 Dec 2021 10:58:27 +0100 Matthieu Baerts wrote:
> > Hi Ye,
> > 
> > On 10/12/2021 08:14, cgel.zte@gmail.com wrote:  
> > > From: Ye Guojin <ye.guojin@zte.com.cn>
> > > 
> > > 'sys/ioctl.h' included in 'mptcp_inq.c' is duplicated.    
> > 
> > Good catch, the modification looks good to me:
> > 
> > Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> > 
> > 
> > This patch is for "net-next" tree as it fixes an issue introduced by a
> > patch only in this tree:
> > 
> > Fixes: b51880568f20 ("selftests: mptcp: add inq test case")
> > 
> > Regarding the commit message, please next time include the Fixes tag and
> > mention for which tree it is for in the FAQ [1], e.g. [PATCH net-next].
> > 
> > 
> > @David/Jakub: do you prefer a v2 with these modifications or is it fine
> > to apply this small patch directly in net-next tree?  
> 
> v1 is fine. Let me apply it right away and do the edits before I forget
> they are needed..

Actually, I take that back, let's hear from Mat, he may want to take
the patch via his tree.