MIME-Version: 1.0
References: <20211210135527.28194-1-wangxiang@cdjrlc.com>
In-Reply-To: <20211210135527.28194-1-wangxiang@cdjrlc.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Fri, 10 Dec 2021 16:17:27 +0100
Message-ID: <CAMRc=MdXxh58zB10jXKO30JmLjXS+yna8kKDPGtip9BfQ9Pg7A@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: bcm-kona: add const to of_device_id
To:     Xiang wangx <wangxiang@cdjrlc.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Ray Jui <rjui@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 10, 2021 at 2:57 PM Xiang wangx <wangxiang@cdjrlc.com> wrote:
>
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
>
> Changes since v1
> * Change subject log
>
>  drivers/gpio/gpio-bcm-kona.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index d329a143f5ec..9cb3587d1441 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -505,7 +505,7 @@ static struct irq_chip bcm_gpio_irq_chip = {
>         .irq_release_resources = bcm_kona_gpio_irq_relres,
>  };
>
> -static struct of_device_id const bcm_kona_gpio_of_match[] = {
> +static const struct of_device_id const bcm_kona_gpio_of_match[] = {
>         { .compatible = "brcm,kona-gpio" },
>         {}
>  };
> --
> 2.20.1
>

Applied, thanks!

Bart

PS: next time please include any ack/review tags already left under
the previous version