Subject: Re: [PATCH] spi: Fix incorrect cs_setup delay handling
To:     Mark Brown <broonie@kernel.org>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Joey Gouly <joey.gouly@arm.com>
References: <20211210153634.171580-1-marcan@marcan.st>
 <YbN+cBQlsLprirxW@sirena.org.uk>
From:   Hector Martin <marcan@marcan.st>
Message-ID: <3c94fa29-6c21-9fbd-b1f5-eb6c846054bb@marcan.st>
Date:   Sat, 11 Dec 2021 01:32:06 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YbN+cBQlsLprirxW@sirena.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: es-ES
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/12/2021 01.21, Mark Brown wrote:
> On Sat, Dec 11, 2021 at 12:36:34AM +0900, Hector Martin wrote:
> 
>> We need to wait *after* asserting CS and before the transfer, not before
>> asserting CS which isn't very useful.
> 
> This needs a better changelog, there's multiple delays being handled
> here and it's not clear from this which are affected here or what the
> problem is.

cs_setup is affected, I thought at least that was clear from the patch 
summary :-)

 From spi.h:

* @cs_setup: delay to be introduced by the controller after CS is asserted

So clearly that delay has to happen at the end of spi_set_cs, *after* 
the assertion, not at the beginning before it.

If you prefer, I can resend it with a reference to the spi.h comment.

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub