Date:   Fri, 10 Dec 2021 16:39:05 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Hector Martin <marcan@marcan.st>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Joey Gouly <joey.gouly@arm.com>
Subject: Re: [PATCH] spi: Fix incorrect cs_setup delay handling
Message-ID: <YbOCqbah03qdLQhK@sirena.org.uk>
References: <20211210153634.171580-1-marcan@marcan.st>
 <YbN+cBQlsLprirxW@sirena.org.uk>
 <3c94fa29-6c21-9fbd-b1f5-eb6c846054bb@marcan.st>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="n+nKIqKK51EAnd7+"
Content-Disposition: inline
In-Reply-To: <3c94fa29-6c21-9fbd-b1f5-eb6c846054bb@marcan.st>
Precedence: bulk


--n+nKIqKK51EAnd7+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Dec 11, 2021 at 01:32:06AM +0900, Hector Martin wrote:
> On 11/12/2021 01.21, Mark Brown wrote:

> > This needs a better changelog, there's multiple delays being handled
> > here and it's not clear from this which are affected here or what the
> > problem is.

> cs_setup is affected, I thought at least that was clear from the patch
> summary :-)

This should be in the commit message, the subject line of the e-mail
isn't super visible when people are reviewing - basically, the body of
the commit message should make sense standalone.

> If you prefer, I can resend it with a reference to the spi.h comment.

Yes, please resend with a clear commit message.

--n+nKIqKK51EAnd7+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGzgqgACgkQJNaLcl1U
h9D8NQf/RH4/0pNggDaJpqCJvUSfbIE6AlkDCulr3IsGAFEAIbhq3OzJjQr4eXLh
qwj2n8VfvwWc5Wb7iGuS6F4JnQsC2zIpyvjGbo7XcsGTWrka1XNQ0xKzGdDtuYma
ubLIIVE1ZlRZM2VFJ4KjOdau0LvX+BMTaMLcP4pnSRl/+bGYdiQAZV/o5cw0sNjA
MQOX9MGy9KapSg3xxa0geijbz9sPeLv10wf2ua7uA9ml32juhcwXEpjB+K/FK+sW
OSe4fsTZQqqlsPCO9jui470WUOv5SoFA81wZPG+7YQeByGSDbuahZpOg/JZstnsS
P2LihXEXipvHDD1rTLTCDI2KEki0FQ==
=9uj2
-----END PGP SIGNATURE-----

--n+nKIqKK51EAnd7+--