MIME-Version: 1.0
References: <1639109105-1545-1-git-send-email-yangtiezhu@loongson.cn> <YbN+0NrHmsFKfNWP@archlinux-ax161>
In-Reply-To: <YbN+0NrHmsFKfNWP@archlinux-ax161>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 11 Dec 2021 01:39:10 +0900
Message-ID: <CAK7LNAS7=qYs7NdDRY+4Dz5Zt0tLDo-W-EMcx+9TaNazNVcX=Q@mail.gmail.com>
Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jason Self <jason@bluehome.net>,
        Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 11, 2021 at 1:22 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> > After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> > {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> > Kbuild.platforms, because the cause of the build issue mentioned
> > in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> > platform") has been disappeared, so just remove it.
> >
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> > ---
> >
> > v2: fix the typo "casue" --> "cause" in the commit message,
> >     sorry for that.
> >
> >  arch/mips/Makefile | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> > index ace7f03..e036fc0 100644
> > --- a/arch/mips/Makefile
> > +++ b/arch/mips/Makefile
> > @@ -253,9 +253,7 @@ endif
> >  #
> >  # Board-dependent options and extra files
> >  #
> > -ifdef need-compiler
> >  include $(srctree)/arch/mips/Kbuild.platforms
> > -endif
> >
> >  ifdef CONFIG_PHYSICAL_START
> >  load-y                                       = $(CONFIG_PHYSICAL_START)
> > --
> > 2.1.0
> >


Nathan's patch cleaned up  arch/mips/loognson2ef/Platform,
but I still see similar code in arch/mips/sgi-ip22/Platform.


ifdef CONFIG_SGI_IP28
  ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
      $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
  endif
endif


Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?


-- 
Best Regards
Masahiro Yamada