Date:   Fri, 10 Dec 2021 19:06:25 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org,
        perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
        rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, swboyd@chromium.org,
        judyhsiao@chromium.org,
        Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [RESEND, v9 06/10] ASoC: qcom: Add regmap config support for
 codec dma driver
Message-ID: <YbOlMdiRc0Xirajz@sirena.org.uk>
References: <1638800567-27222-1-git-send-email-quic_srivasam@quicinc.com>
 <1638800567-27222-7-git-send-email-quic_srivasam@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="WSzyGP1U7OF5nLGs"
Content-Disposition: inline
In-Reply-To: <1638800567-27222-7-git-send-email-quic_srivasam@quicinc.com>
Precedence: bulk


--WSzyGP1U7OF5nLGs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 06, 2021 at 07:52:43PM +0530, Srinivasa Rao Mandadapu wrote:

> +static bool __lpass_rxtx_regmap_accessible(struct device *dev, unsigned int reg, bool rw)
> +{
> +	struct lpass_data *drvdata = dev_get_drvdata(dev);
> +	struct lpass_variant *v = drvdata->variant;
> +	int i;
> +
> +	for (i = 0; i < v->rxtx_irq_ports; ++i) {

> +	for (i = 0; i < v->rxtx_rdma_channels; ++i) {

This is looking relatively expensive to run with all these loops -
there's a reason these are normally written as switch statements, the
theory being that the compiler will generate something at least as good
as any data structure we're likely to code.  It's not a *problem*
exactly, but if you're doing anything that ends up querying properties a
lot it might be an issue.

--WSzyGP1U7OF5nLGs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGzpTAACgkQJNaLcl1U
h9BOWAf+MVXmAYTXdCSSLIWm9urbvgPo+9iMFnLJXtBKu9dWuX1r3zSzZP9eO4dJ
MGGQvq0wylkBP+CxyNf8IrJX0YN/KUnh/C3pE21qQj6VQkBjUlIs6MWkGqXsob7r
zICYs1btoqDSkkOsnlvpjoWLROOX6egusSYw7p02SaA2hKfSQfoCcGLP5GSZiiF6
2TwHuFDB2Iu9qT+hf7BBHNAHDFU9BJJZB5EJwXdjC538fI/QlCKk4ARDllzVMk8H
oy3Enodc2t+Xgg3E7r4Ea/7BE8sSex8zFHaoyNMlYpYelFzBFIPuiAw1SH5sN3I1
Sh9cfGTfvBJ1VVRedUc0Ly4ssXuj0g==
=inw7
-----END PGP SIGNATURE-----

--WSzyGP1U7OF5nLGs--