Message-ID: <db65cd76-e2c0-4d35-0dcc-d9f8c164f77e@oracle.com>
Date:   Fri, 10 Dec 2021 13:53:59 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v16 00/11] support reserving crashkernel above 4G on arm64
 kdump
Content-Language: en-US
To:     Catalin Marinas <catalin.marinas@arm.com>,
        Zhen Lei <thunder.leizhen@huawei.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org, Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211123124646.1995-1-thunder.leizhen@huawei.com>
 <YbDnwol20HrRl4uL@arm.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <YbDnwol20HrRl4uL@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGx2WTBjVldUOUhPRlFnKzVrM2RqYWVSdW1qSW02VlVHajZkT3VlZDBUWXZR?=
 =?utf-8?B?R3JYaVB5cUxCVGRVRkdDaklqWWJHTi9oTUVnbHk3MlZMNGFDNlErT21UcXpu?=
 =?utf-8?B?TG5uWGRrSm9WSStJNDdKWDc1dGhkTlBkSHNBTkVuSUZsaHZ4UFpJRlM4NlhL?=
 =?utf-8?B?cCtHRzFQODJvODd0akttRW94WXExeFlNVjZ5bHhvVTJNNVlNVmdtVXNkTWZJ?=
 =?utf-8?B?U3hSVEpmZk1LZmhvUzRRLzNjMU5ZUTNSbVNFMlhGT25GRDJpeThJeGkwS3Jr?=
 =?utf-8?B?TVZPdHJtL0t2UUNMaURmVTJXMnRSRnE0RTJZdmFwTHkyS05GN2NSTmFvUWtm?=
 =?utf-8?B?cmc2NWhZNVQ2ZGZ6L0lEdDRqSnZ1OHAwbU50TzhPMnpJOGxqamk3cGhXS1Iz?=
 =?utf-8?B?RnA2ZUIwZ2trTVpvNHdvTWpZL2xxWlZQZUdTNEVVcTZZa05xTUN2aEEzaTk5?=
 =?utf-8?B?S0tEcDd3UU5XSkJnRW5GNVJnSEhvVzlFVEtZaWFWdy9RbWJabjNoZUpwYW5t?=
 =?utf-8?B?L2orSGhudjBpazNQbjdPNWJ2MDc4eEF6QUZxVHkwaGptcHRMT3UxNXBwcXJM?=
 =?utf-8?B?MGV5aTZuVU42d2NqSkN4WHVmQ3NFTzdkbHJvTk5WNHNhMmlnNEZNeG5KVXVB?=
 =?utf-8?B?Wm8wQ3d4MlpCNWFoWkVSYXdiSmdtRndsbks3Qk1TZVhBQWp3UUlWUjVuSHlD?=
 =?utf-8?B?VG9IdFp3ZVNJRlNZYkVld3VsaFZ3bjdPRWNkSUErUUdyNThaTk9qbDNYQWZB?=
 =?utf-8?B?Mm12NHpFYlAwcEkxZ1JBWExGNnpjMnVybHFOUkdTOW1nQkZLNTQzZ1R5MEw5?=
 =?utf-8?B?VEZRYnRwdExlYy9tSGRMUzFUemt2N1g2ajVIUjR6RGwwNjBoWWptcEJieC9P?=
 =?utf-8?B?ZlkvSmF2Q2R5SkQybE4vTU5PSXI2ZGxOZFZoUWIxN2w2blg2b0FZYVZPL2l6?=
 =?utf-8?B?NTF3cWFka0s3THpoZFYrTTNQZ3NoVjJVMFhHcElsdll6RzVhUy9PZWd5K2V2?=
 =?utf-8?B?WVZKeEdOT0JLdWYvTlcySzhMaVFYV2tSdVVZSDcvYXYvVmdQbWwwNEo0Tm9O?=
 =?utf-8?B?VWlFZk13aGRoNG9UT0VLOWtJNU0wY1N2OUx6Z0R3aXRPT2ZWT2dTd3Y5Nm9w?=
 =?utf-8?B?VWFVcE0zKytvUXF6Sk1ibXZyd1NMRkVKSWg0OW12ZFJwN053WmRySFZnd3hX?=
 =?utf-8?B?dllMdUdwdlFEZ0dWbm5kMGVrUTNUbGlUUEVlZVFQYStLNkJBQmI4dkpTQllV?=
 =?utf-8?B?M0sxU0tnSkMxeTJwbEhaNUo5RUlaLzJaMzlBU2JmNXg3VEhSMlVHSDZaRkIx?=
 =?utf-8?B?Qis5bWdUTklwWmZmNjBETXJvcGJxaElUQ3Q1bThjbTN6WWtiRWNVVzhFeFQv?=
 =?utf-8?B?YStSczkySGU2WDRRdUcwbUJhM2RhV2lETEZaazkyVUgzMmRON0xVN045SG1w?=
 =?utf-8?B?eHhOMVA3d3psUTMxRmhqR1oxdDJFOG52OCtncWUvYVZKY2ZqWXozL3ZxK0Jn?=
 =?utf-8?B?clo5N243eG05NHd5V1lqYjRnWFZHZmRJRmFUQ1V5dVVNT2RtcS9abzVvWmhz?=
 =?utf-8?B?NHhVSzdIWkIxNGxJZmFTZldJRHF1cStQM1h1RTJGK3VMOStVejlSc0hJRU9q?=
 =?utf-8?B?T3hVaFNSckNTMEg5c1hQNW0zMXBIT3VjZFNpRUpFanFOVXkxVCtMb24zbEkr?=
 =?utf-8?B?S3FoVk9TZ3RhTWpMbXRFSVBsUXdORmlSRnk4RDVkcE1NcHZhcGpwNmE5aTdz?=
 =?utf-8?B?OS96MkhpS0p3MVJiMFBxWHhtenRLRklSYjM2V2U3cDBDcnBITmc2R0toRWFk?=
 =?utf-8?B?WlN6c21XTVBUcFU4WGVybXB0NURlMUxRTjQ5NDdxb0pHeWxwcm4wcFJIcUdx?=
 =?utf-8?B?bUtaQW40V1dOMWxIQkdTWGtvNDBha01hWCtRYzVtQ0gwNkRmTVlCWDd6TitU?=
 =?utf-8?B?VEhRaTJsSCtNdkN2VW5kWEpGZUlhc3lWMEZRN25NKzJEMHY4Z0Z5bFpMSno0?=
 =?utf-8?B?R2p2Wk5pVWdmZDh5NkdBWEU5UmJ4WTNNbXpKbGh2aGpqT2VDNExTTGs3Mko0?=
 =?utf-8?B?bUxGc2c5RkUrVVVWWEZic1hkZ3lxeDM1NHZha0R1L052Q2QwNlBCaXd5TVJr?=
 =?utf-8?B?QkVCN1BaRURwUi9SQW9KR0FpcDVwWmN6ay84NzlYUzN3SHhlaE5yNmRMQWty?=
 =?utf-8?B?a3hPQmw3Z2VCNHc5YVFwbnphSEpDV0l5VE9zQUo1S2JPWlNHZ0M1aW5CT2xo?=
 =?utf-8?B?TlE3Wmx0N1RMVHpkd252NTE5ckJBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ede8be2-ac24-4aa9-f148-08d9bc16da7a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 19:54:19.1678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ONfGw6CAIEobK3CrZRf1y7S5bdkzBQkci+tMeCu1jUXJ+SvOuJ8kTfofzAJj2R6OfS6b0JZRVLrQD7gQST+s8QwIZO2NDt5/E6EwVpZPSF8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1967
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10194 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112100108
X-Proofpoint-GUID: i7eTLgqqph8KsA8GrfFnIkm99tmc1qPY
X-Proofpoint-ORIG-GUID: i7eTLgqqph8KsA8GrfFnIkm99tmc1qPY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/8/21 11:13 AM, Catalin Marinas wrote:
> On Tue, Nov 23, 2021 at 08:46:35PM +0800, Zhen Lei wrote:
>> Chen Zhou (10):
>>    x86: kdump: replace the hard-coded alignment with macro CRASH_ALIGN
>>    x86: kdump: make the lower bound of crash kernel reservation
>>      consistent
>>    x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions
>>      reserve_crashkernel()
>>    x86: kdump: move xen_pv_domain() check and insert_resource() to
>>      setup_arch()
>>    x86: kdump: move reserve_crashkernel[_low]() into crash_core.c
>>    arm64: kdump: introduce some macros for crash kernel reservation
>>    arm64: kdump: reimplement crashkernel=X
>>    x86, arm64: Add ARCH_WANT_RESERVE_CRASH_KERNEL config
>>    of: fdt: Add memory for devices by DT property
>>      "linux,usable-memory-range"
>>    kdump: update Documentation about crashkernel
>>
>> Zhen Lei (1):
>>    of: fdt: Aggregate the processing of "linux,usable-memory-range"
> 
> Apart from a minor comment I made on patch 8 and some comments from Rob
> that need addressing, the rest looks fine to me.
> 
> Ingo stated in the past that he's happy to ack the x86 changes as long
> as there's no functional change (and that's the case AFAICT). Ingo, does
> your conditional ack still stand?
> 
> In terms of merging, I'm happy to take it all through the arm64 tree
> with acks from the x86 maintainers. Alternatively, with the change I
> mentioned for patch 8, the first 5 patches could be queued via the tip
> tree on a stable branch and I can base the rest of the arm64 on top.
> 
> Thomas, Ingo, Peter, any preference?
> 
> Thanks.
> 

Hi,

If you notice the trend over the past year , some of additional review 
requests are because the submitter had to rebase to the next version.

Can we get this acked and placed in a build so others can test and start 
using it ?

Thank you,
JD