From:   Bradley Scott <Bradley.Scott@zebra.com>
To:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Hui Wang <hui.wang@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Kailang Yang <kailang@realtek.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Sami Loone <sami@loone.fi>, Elia Devito <eliadevito@gmail.com>,
        alsa-devel@alsa-project.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Bradley Scott <Bradley.Scott@zebra.com>
Subject: [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6
Date:   Fri, 10 Dec 2021 14:26:12 -0500
Message-Id: <20211210192614.460529-1-Bradley.Scott@zebra.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZV5KRmgfLmGzd4oTv9BePBjcBHOW8k3zbQnbiLf9BKp0qutC1xV0XPC9Kjqv?=
 =?us-ascii?Q?Zfo16WuPJ0Zxg+B0P4sqTkfqPf8//u8LX8HXVtRBOCBO46oiQXowu21cunCw?=
 =?us-ascii?Q?Jmc9V/k9xHwpIQl7K1VQGCMGje1fvm5ihpISkAPR+bG55j6sLD1Ob6F7Ksvp?=
 =?us-ascii?Q?3AlaAhDA/UdoKiKker9rP1iwnVUmXpRpTy//JRGKIF41tOeUqcWyPb6DOVqM?=
 =?us-ascii?Q?aUjBf0aC1cusprj3LnV+76F1+Qf+qmkijauZR69WjhHVdULMZllQ8haDeDQw?=
 =?us-ascii?Q?TyLa5WEC/U0yoCPmnn1YML2jklp9mT8KNqyrO+zEzL1j57X6FWpd9fGlX/04?=
 =?us-ascii?Q?yAR+PlTlDuntp6VvSQ6IF7/IAduEcvCvfY3Vafr7lOVK8vXhymhJzHQiWVE8?=
 =?us-ascii?Q?ePTZk8J26TAsRb45hJZMRmS86HXGIozadgn3/nLHwtNC3hGDd1qt0On650a9?=
 =?us-ascii?Q?DKUbKKtKZJ5U9Vzf40+phR4SoM/mSoIF42JNeo6Qej79asHwbma4VFp1g09V?=
 =?us-ascii?Q?4bQJ6m8X/ZtkNt8AyOmESY//9kfYgtS/a8YS06p6jEBLtDLRFGBdOQscmYNq?=
 =?us-ascii?Q?yztD5Wi1cyAD1YEo8PhpsSAW3g9Y1FMAziqaDQoPx6AgrkYPiyhg5UxcOc9i?=
 =?us-ascii?Q?9VnEL7/zJBbgwQbu1JYLFyFeXbC13QDtlkzBkdE384Oh0MBWRK//q6IbzR/j?=
 =?us-ascii?Q?CRtKunfRjmO60642vcTQkWdygbWTpMUtg+dvT/soRomwCEIIXQYnEFnx4KLH?=
 =?us-ascii?Q?UwNQhbn8Y/k+NaIc4kZlw6R8bx2u9jENfuUHKTSLJsAevA6a/Birn7TGO/Of?=
 =?us-ascii?Q?Q56qtFwMq7Htbk0fh9Mev4UiJCFBZ08idBa2kPICIeaZONxowIC1HTgPTdU2?=
 =?us-ascii?Q?D5BK2y8nj7rvT6cczjRJceMk7LezfqoqsN9oxlqTvKREdFSOIiYkssw1jyuG?=
 =?us-ascii?Q?7fjaWQlMl+nM3//Ejf8aLEVo5AGVK2UAPGgwPXLTusYclz92JVEYPlccWvxg?=
 =?us-ascii?Q?Yax0cpJRPLpN8C/6dAa94ZuK4o9vA/FwhsNiScjkLIAFObesO4nwsb1dSCZT?=
 =?us-ascii?Q?TmIGDhVGt/qkk0P2Mm+7YovqysB0ls5wJclPdp7PNN9RkdaTNsWJzA5im0L0?=
 =?us-ascii?Q?TsEWTQchIE+gIFgi3e0RhLS1IghxWSbBi4MJeMEYwo2yUj8zwLXjHMl6COT3?=
 =?us-ascii?Q?gI6soUHjBhNq1aU4hrZlSEGKv20CMzJggqHnSR+YoJMvZKVCRXT+5yFRYzyQ?=
 =?us-ascii?Q?fp2elbITxbJ1mPcp3gCnuM+rgDFM6GbmuyrjRCS9OBLV14z2Munh0PhzKvrx?=
 =?us-ascii?Q?aAU0XO2H5/yRm2AIwuPOFFexKSrw3uQZ8j4PI1mTYwUyjRysF9xdUKdKwbVE?=
 =?us-ascii?Q?5fDy6BK9n9lTiMnC/1ULGhjxLX/tGJ1vzq8TkwnXK9B3Mg5jqheUDH+k7FIc?=
 =?us-ascii?Q?Kyem/4N5fSpqItPiBsCn7l+oeuslFix7+r6ki21AoIkX+oDSAuiN/X2tMEzG?=
 =?us-ascii?Q?IEtnkXi7bGq5SfkCDyL2CCQZTJpNKXFScjNGG6UfcrpoOEm1S4DKC89qMmvY?=
 =?us-ascii?Q?dzuCJMmE0pGHUN9wOxEkvwhRhK9+t/3z9M3wBEDsaT+Onr2aDhlaH8arIJ6g?=
 =?us-ascii?Q?iqASZMoaDfmTzuddkCjAXSc=3D?=
X-OriginatorOrg: zebra.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac7a3db2-ec1d-4912-c738-08d9bc135626
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4668.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 19:29:08.7449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4d3d260a-9c40-4306-8dac-0d64717039ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yve5TXHSqMYZ9RHZtFhJ3DzkifdmLAchPKDhQsRWI9gKyQGyxr3Kub7byESzNFd4N5ZRgQ+6AaceiSEs+pctOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3977
X-Proofpoint-ORIG-GUID: Zk8yBOxy_VIvnPFllO0Td1ztlm30sMpn
X-Proofpoint-GUID: Zk8yBOxy_VIvnPFllO0Td1ztlm30sMpn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-10_07,2021-12-10_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0
 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0
 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0
 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112100106
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier
initialization as used on several other HP laptops using ALC285.

This commit also adds a new "alc285-hp-amp-init" model that can be used
to apply this same amp init fixup to other devices by passing
"hda_model=3Dalc285-hp-amp-init" to the snd-sof-intel-hda-common module or
"model=3Dalc285-hp-amp-init" to the snd-hda-intel module, depending on
which is being used.

Signed-off-by: Bradley Scott <Bradley.Scott@zebra.com>
---
 Documentation/sound/hd-audio/models.rst | 2 ++
 sound/pci/hda/patch_realtek.c           | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/Documentation/sound/hd-audio/models.rst b/Documentation/sound/=
hd-audio/models.rst
index 0ea967d34583..d25335993e55 100644
--- a/Documentation/sound/hd-audio/models.rst
+++ b/Documentation/sound/hd-audio/models.rst
@@ -326,6 +326,8 @@ usi-headset
     Headset support on USI machines
 dual-codecs
     Lenovo laptops with dual codecs
+alc285-hp-amp-init
+    HP laptops which require speaker amplifier initialization (ALC285)

 ALC680
 =3D=3D=3D=3D=3D=3D
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3599f4c85ebf..fc41f3e8ddc3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8660,6 +8660,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] =
=3D {
        SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_=
OMEN),
        SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUT=
E_LED_MIC3),
        SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_F=
IXUP_HP_SPECTRE_X360),
+       SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPI=
O_AMP_INIT),
        SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP=
_HP_GPIO_AMP_INIT),
        SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
        SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENV=
Y_GPIO),
@@ -9123,6 +9124,7 @@ static const struct hda_model_fixup alc269_fixup_mode=
ls[] =3D {
        {.id =3D ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name =3D "alc287-ideap=
ad-bass-spk-amp"},
        {.id =3D ALC623_FIXUP_LENOVO_THINKSTATION_P340, .name =3D "alc623-l=
enovo-thinkstation-p340"},
        {.id =3D ALC255_FIXUP_ACER_HEADPHONE_AND_MIC, .name =3D "alc255-ace=
r-headphone-and-mic"},
+       {.id =3D ALC285_FIXUP_HP_GPIO_AMP_INIT, .name =3D "alc285-hp-amp-in=
it"},
        {}
 };
 #define ALC225_STANDARD_PINS \
--
2.25.1


________________________________
- CONFIDENTIAL-

This email and any files transmitted with it are confidential, and may also=
 be legally privileged. If you are not the intended recipient, you may not =
review, use, copy, or distribute this message. If you receive this email in=
 error, please notify the sender immediately by reply email and then delete=
 this email.