From:   Jonathan Corbet <corbet@lwn.net>
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Kees Cook <keescook@chromium.org>,
        David Gow <davidgow@google.com>
Cc:     Brendan Higgins <brendanhiggins@google.com>, Tim.Bird@sony.com,
        shuah@kernel.org, rmr167@gmail.com, guillaume.tucker@collabora.com,
        dlatypov@google.com, kernelci@groups.io,
        kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification
In-Reply-To: <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org>
References: <20211207190251.18426-1-davidgow@google.com>
 <202112071358.E8E6812D@keescook>
 <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org>
Date:   Fri, 10 Dec 2021 14:05:41 -0700
Message-ID: <87mtl8qifu.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Shuah Khan <skhan@linuxfoundation.org> writes:

> On 12/7/21 3:02 PM, Kees Cook wrote:
>> On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote:
>>> From: Rae Moar <rmoar@google.com>
>>>
>>> It does not make any significant additions or changes other than those
>>> already in use in the kernel: additional features can be added as they
>>> become necessary and used.
>>>
>>> [1]: https://testanything.org/tap-version-13-specification.html
>>>
>>> Signed-off-by: Rae Moar <rmoar@google.com>
>>> Co-developed-by: David Gow <davidgow@google.com>
>>> Signed-off-by: David Gow <davidgow@google.com>
>> 
>> I like it! Thank you so much for suffering through my earlier reviews.
>> :)
>> 
>> The only concern I have is wonder what'll be needed to kselftest to
>> deal with indentation changes. As long as this can be implemented
>> without a subtest knowing it is a subtest, we're good.
>> 
>
> A lot of this TAP output is in the wrappers - hopefully it will be okay.
> Fingers crossed. :)
>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
>> 
>
> Looks good to me as well. Thanks for doing this work.
>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

Would you like me to take this through the docs tree, or do you have
other plans for merging?

Thanks,

jon